-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Organization in Breadcrumb Nav Bar #7213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chef-automate ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vinay033
reviewed
Jul 15, 2022
(pageChanged)="onPageChange($event)"> | ||
</app-page-picker> | ||
</div> | ||
</div> | ||
</section> | ||
</main> | ||
</div> | ||
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add one line here
vinay033
approved these changes
Jul 15, 2022
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
450426e
to
2f69a46
Compare
Kudos, SonarCloud Quality Gate passed!
|
Dmaddu
approved these changes
Jul 18, 2022
kalroy
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sahiba31 sahibagoyal1999@gmail.com
🔩 Description: What code changed, and why?
When navigating in Automate under Infrastructure / Chef Infra Servers the Organization gets lost from the breadcrumb navigation. So I have added the code so that the Org should stay visible and clickable in the breadcrumbs.
⛓️ Related Resources
https://chefio.atlassian.net/browse/KINETICS-170
https://chefio.atlassian.net/browse/KINETICS-145
👍 Definition of Done
After changing the code, now Organization is visible and clickable in the breadcrumbs for all the required tabs and clicking the organisation in the breadcrumb in Chef Infra Server take the user to the cookbook tab.
👟 How to Build and Test the Change
After going to my branch run these commands:
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable