Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Organization in Breadcrumb Nav Bar #7213

Merged
merged 9 commits into from
Jul 18, 2022

Conversation

Sahiba31
Copy link
Contributor

@Sahiba31 Sahiba31 commented Jun 29, 2022

Signed-off-by: Sahiba31 sahibagoyal1999@gmail.com

🔩 Description: What code changed, and why?

When navigating in Automate under Infrastructure / Chef Infra Servers the Organization gets lost from the breadcrumb navigation. So I have added the code so that the Org should stay visible and clickable in the breadcrumbs.

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-170
https://chefio.atlassian.net/browse/KINETICS-145

👍 Definition of Done

After changing the code, now Organization is visible and clickable in the breadcrumbs for all the required tabs and clicking the organisation in the breadcrumb in Chef Infra Server take the user to the cookbook tab.

👟 How to Build and Test the Change

After going to my branch run these commands:

  • hab studio enter
  • build components/automate-ui-devproxy/
  • start_automate_ui_background
  • start_all_services
  • rebuild components/automate-ui/

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 2f69a46
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/62d4facf19a6c8000851228b
😎 Deploy Preview https://deploy-preview-7213--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Sahiba31
Copy link
Contributor Author

Sahiba31 commented Jun 29, 2022

As you can see in the Breadcrumbs nav bar, the org name(demoorg) is visible and clickable.
Screenshot 2022-06-29 at 3 08 45 PM

When we click on organization name (demoorg) it will redirect to Organization's page as you can see below:
Screenshot 2022-07-12 at 6 07 54 PM

@kalroy kalroy marked this pull request as ready for review June 29, 2022 11:12
(pageChanged)="onPageChange($event)">
</app-page-picker>
</div>
</div>
</section>
</main>
</div>
</div>
</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add one line here

Sahiba31 and others added 9 commits July 18, 2022 11:46
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba31 <sahibagoyal1999@gmail.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
@Dmaddu Dmaddu force-pushed the sahiba/automate-navigation-kinetics145 branch from 450426e to 2f69a46 Compare July 18, 2022 06:16
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 18520d8 into main Jul 18, 2022
@kalroy kalroy deleted the sahiba/automate-navigation-kinetics145 branch July 18, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants