Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show profiles data in compliance report #7215

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

Sunanda-Boorla
Copy link
Collaborator

@Sunanda-Boorla Sunanda-Boorla commented Jun 29, 2022

Signed-off-by: Sunanda-Boorla sboorla@progress.com

πŸ”© Description: What code changed, and why?

Removed this.isEmpty(data.items) as this was showing profiles data empty and replaced with this.isZero(data.total) to show profiles data in compliance report. Code is modified in order to show complete profiles.

⛓️ Related Resources

https://chefio.atlassian.net/jira/software/c/projects/MADROX/boards/363?modal=detail&selectedIssue=MADROX-227

πŸ‘ Definition of Done

  • If we click passed nodes, skipped nodes or waived nodes, then it should display profiles data.
  • The bar containing total, passed, failed profiles should be still there
  • The message for no data list should contain the type of filter selected

πŸ‘Ÿ How to Build and Test the Change

start_all_services
rebuild components/report-manager-service/
rebuild components/compliance-service/
rebuild components/automate-gateway/
rebuild components/automate-cli/
rebuild components/automate-deployment/
rebuild components/automate-ui/

Run scan job and try to see data under nodes and profiles

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Screen.Recording.2022-06-29.at.8.37.58.PM.mov

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>
@netlify
Copy link

netlify bot commented Jun 29, 2022

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 0d6952d
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/62bc7ca431d44a00082cf90e

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vivek-yadav vivek-yadav merged commit 976b962 into main Jul 4, 2022
@vivek-yadav vivek-yadav deleted the sunanda/compliance-report-bug branch July 4, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants