-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanju/customer bug kinetics 142 #7243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
π· Deploy Preview for chef-automate processing.
|
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
308b71f
to
0b89cb2
Compare
vinay033
reviewed
Jul 18, 2022
...tomate-ui/src/app/page-components/manual-upgrade-banner/manual-upgrade-banner.component.html
Outdated
Show resolved
Hide resolved
vinay033
approved these changes
Jul 18, 2022
Dmaddu
approved these changes
Jul 18, 2022
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Kudos, SonarCloud Quality Gate passed!Β Β
|
kalroy
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π© Description: What code changed, and why?
Chef Automate disclosure banner missing.
βοΈ Related Resources
https://chefio.atlassian.net/browse/KINETICS-142
π Definition of Done
Added the Banner in the chef-automate
π How to Build and Test the Change
rebuild the automate-ui
rebuild components/automate-ui
add banner configuration in
dev/patch.toml
file.then apply this configuration using
chef-automate config patch dev/patch.toml
β Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
π· Screenshots, if applicable