Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanju/customer bug kinetics 142 #7243

Merged
merged 8 commits into from
Jul 18, 2022
Merged

Conversation

SanjuPal01
Copy link
Collaborator

@SanjuPal01 SanjuPal01 commented Jul 11, 2022

πŸ”© Description: What code changed, and why?

Chef Automate disclosure banner missing.

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-142

πŸ‘ Definition of Done

Added the Banner in the chef-automate

πŸ‘Ÿ How to Build and Test the Change

rebuild the automate-ui
rebuild components/automate-ui

add banner configuration in dev/patch.toml file.

[global.v1]
  [global.v1.banner]
    show = true
    message = "Changing the text around"
    background_color = "3864f2" # Must be a hex value minus the hash symbol
    text_color = "FFF" # Must be a hex value minus the hash symbol

then apply this configuration using
chef-automate config patch dev/patch.toml

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

@netlify
Copy link

netlify bot commented Jul 11, 2022

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 8deb9f0
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/62d506551df579000938dc45

Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2022

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 8b9e5d3 into main Jul 18, 2022
@kalroy kalroy deleted the sanju/customer_bug_kinetics-142 branch July 18, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants