Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Client on Node Deletion of Infra Server View #7271

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

kalroy
Copy link
Collaborator

@kalroy kalroy commented Jul 24, 2022

Infra Server Node deletion was not deleting clients. The message on node deletion although claims to delete the corresponding client too.

⛓️ Related Resources

https://chefio.atlassian.net/browse/STALWART-196

👍 Definition of Done

  • Connect Infra Server to Infra Server View
  • Search for a node under Nodes tab
  • Search for the same name in the Clients tab. You should find the client in the client tab.
  • Delete the node from the Nodes tab
  • After deletion, the clients tab should not return the client name

👟 How to Build and Test the Change

  • rebuild components/infra-proxy-service
  • start_all_services
  • Use server ec2-18-223-220-58.us-east-2.compute.amazonaws.com
  • admin kallol

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Kallol Roy <kallol.roy@progress.com>
Signed-off-by: Kallol Roy <kallol.roy@progress.com>
@netlify
Copy link

netlify bot commented Jul 24, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 0a6091e
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/62dd951e45f46d000808e47e

@kalroy kalroy changed the title ### 🔩 Description: What code changed, and why? ### Delete Client on Node Deletion of Infra Server View Jul 24, 2022
@kalroy kalroy changed the title ### Delete Client on Node Deletion of Infra Server View Delete Client on Node Deletion of Infra Server View Jul 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kalroy kalroy merged commit 10e86d5 into main Jul 27, 2022
@kalroy kalroy deleted the stalwart-196-fix branch July 27, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants