Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled duplicate empty key errors on report ingestion #7379

Merged
merged 5 commits into from Sep 28, 2022

Conversation

vivekshankar1
Copy link
Collaborator

🔩 Description: What code changed, and why?

Compliance report ingestions were getting failed when properties had duplicate empty values.
https://chefio.atlassian.net/browse/IN-835

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Sep 1, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 46cc70d
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6333d21d786ac6000834b39e

Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Dmaddu Dmaddu merged commit 0825439 into main Sep 28, 2022
@Dmaddu Dmaddu deleted the vshankar/report-ingest branch September 28, 2022 05:41
abinash-sudo pushed a commit to abinash-sudo/automate that referenced this pull request Sep 28, 2022
* report ingest

Signed-off-by: Vivek Shankar <vshankar@progress.com>

* report ingest

Signed-off-by: Vivek Shankar <vshankar@progress.com>

* report ingest

Signed-off-by: Vivek Shankar <vshankar@progress.com>

* report ingest

Signed-off-by: Vivek Shankar <vshankar@progress.com>

* report ingest

Signed-off-by: Vivek Shankar <vshankar@progress.com>

Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: abinash-sudo <aprusty1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants