Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding config driven backup for Object storage and File system in Existing infra architecture #7410

Merged
merged 26 commits into from
Sep 26, 2022

Conversation

ArvinthC3000
Copy link
Collaborator

@ArvinthC3000 ArvinthC3000 commented Sep 13, 2022

🔩 Description: What code changed, and why?

In Automate HA as a product, the user who uses the existing_infra architecture wants to patch the backup configuration on deployment. In this PR following types of backup can now be configured during deployment itself.

  • Object storage (similar to s3)
  • File system

⛓️ Related Resources

Jira ticket: https://chefio.atlassian.net/browse/MADROX-318

👍 Definition of Done

It is dev done and tested

👟 How to Build and Test the Change

  • Use the following package to create cli
    arvinth/automate-cli/0.1.0/20220915120343
  • Use the following package for creating test bundles
arvinth/automate-ha-cluster-ctl/0.1.0/20220915165942
arvinth/automate-ha-deployment/0.1.0/20220918125017

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Deployment output (with object storage)

image

Backup-create output (From automate node):
image

Backup-create output (From chef-server node):
image

Deployment output (with file system)

image

Backup-create output (From automate node):
image

@netlify
Copy link

netlify bot commented Sep 13, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 2a8c5d4
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/632db4f30cf8e6000841ce7e

@ArvinthC3000 ArvinthC3000 changed the title Adding config driven backup for Object storage and File system in Existing infra architecture [WIP]Adding config driven backup for Object storage and File system in Existing infra architecture Sep 14, 2022
@ArvinthC3000 ArvinthC3000 changed the title [WIP]Adding config driven backup for Object storage and File system in Existing infra architecture Adding config driven backup for Object storage and File system in Existing infra architecture Sep 19, 2022
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@ArvinthC3000 ArvinthC3000 requested a review from a team as a code owner September 20, 2022 10:23
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Sep 20, 2022
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@github-actions github-actions bot removed the documentation Anything related to the Automate docs. label Sep 20, 2022
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@punitmundra punitmundra merged commit 6683d61 into main Sep 26, 2022
@punitmundra punitmundra deleted the madrox-318 branch September 26, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants