enabling dot match regex #7437
Merged
enabling dot match regex #7437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing.
|
Dmaddu
force-pushed
the
KINETICS-214
branch
2 times, most recently
from
9eceb63
to
ab9d5d2
Compare
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Dmaddu
force-pushed
the
KINETICS-214
branch
from
ab9d5d2
to
2aede11
Compare
Dmaddu
requested review from
iamazzeez,
Sahiba31,
Sahiba3108,
SanjuPal01 and
kalroy
and removed request for
Sahiba31
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
|
|
iamazzeez
requested changes
Sep 28, 2022
iamazzeez
approved these changes
Sep 28, 2022
Sahiba3108
approved these changes
Sep 28, 2022
SanjuPal01
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://chefio.atlassian.net/browse/KINETICS-214
🔩 Description: What code changed, and why?
updated the regular expression to allow the search string that contains dot(.) while node and client search.
⛓️ Related Resources
👍 Definition of Done
The end user should be able to search for node names and client names with dot(.) combinations.
ex: test-123-45.test-test.test.test.com
👟 How to Build and Test the Change
rebuild components/automate-ui
start_all_services
From automate UI, link external infra server.
Goto Nodes tab under the organizations.
Search for Node name with a string having a dot(.)
It should display the search results
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable