Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cert rotate command for HA Service #7494

Merged
merged 9 commits into from
Oct 31, 2022
Merged

Add cert rotate command for HA Service #7494

merged 9 commits into from
Oct 31, 2022

Conversation

Sahiba3108
Copy link
Collaborator

@Sahiba3108 Sahiba3108 commented Oct 19, 2022

Signed-off-by: Sahiba3108 sgoyal@progress.com
SanjuPal01 ssanju@progress.com

🔩 Description: What code changed, and why?

Added the cert rotate command for HA service. Now user has to pass the certificate paths to cert-rotate cmd and it will rotate the certificates of all automate and chef-server nodes

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-234
https://chefio.atlassian.net/browse/KINETICS-230

👍 Definition of Done

👟 How to Build and Test the Change

Add this package in your manifest while deploying HA:
sahiba3108/automate-ha-deployment/0.1.0/20221028084038

Install this cli in your bastion host:
sahiba3108/automate-cli/0.1.0/20221029071324

Run the below command in bastion:
chef-automate cert-rotate --a2 --private-cert certs/private.cert --public-cert certs/public.cert
(You can also use --automate flag instead of a2)
This will rotate the public and private cert of all automate nodes.

chef-automate cert-rotate --cs --private-cert certs/private.cert --public-cert certs/public.cert
(You can also use --chefserver flag instead of cs)
This will rotate the public and private cert of all chef server nodes.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2022-10-28 at 12 56 11 PM

Screenshot 2022-10-28 at 12 58 30 PM

@netlify
Copy link

netlify bot commented Oct 19, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit e74df27
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/635cd3a9f33db0000855c8ce

Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
@ArvinthC3000 ArvinthC3000 self-requested a review October 29, 2022 07:24
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

10.6% 10.6% Coverage
0.0% 0.0% Duplication

@Dmaddu Dmaddu merged commit 5fdce34 into main Oct 31, 2022
@Dmaddu Dmaddu deleted the kinetics-234/certRotate branch October 31, 2022 07:36
@Sahiba3108 Sahiba3108 self-assigned this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants