Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding clean up logic for AWS provisioning #7519

Merged
merged 6 commits into from Nov 8, 2022
Merged

Conversation

ArvinthC3000
Copy link
Collaborator

@ArvinthC3000 ArvinthC3000 commented Oct 31, 2022

Signed-off-by: Arvinth C arvinth.chandrasekaran@progress.com

🔩 Description: What code changed, and why?

In this PR, Cleanup script for AWS provisioning is added

Commands available:

  • --aws-deployment

Example:
chef-automate cleanup --aws-deployment --force

⛓️ Related Resources

Jira Ticket: https://chefio.atlassian.net/browse/MADROX-354

👍 Definition of Done

It's dev done and tested

👟 How to Build and Test the Change

  • Use following CLI package to create chef-autoomate utility
  • Use the following 'HA Deployment' package to create the airgap-bundle for provisioning

CLI package: arvinth/automate-cli/0.1.0/20221103103437
Backend-deployment packages: arvinth/automate-ha-deployment/0.1.0/20221102173230

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

image

@netlify
Copy link

netlify bot commented Oct 31, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 67dab5d
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6369f7bce59cdb0009c4fa56

@ArvinthC3000 ArvinthC3000 force-pushed the ar/aws_cleanup branch 3 times, most recently from 3839814 to b2e9744 Compare November 3, 2022 11:00
@ArvinthC3000 ArvinthC3000 requested a review from a team as a code owner November 3, 2022 11:43
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Nov 3, 2022
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
.
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
.
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

4.8% 4.8% Coverage
0.0% 0.0% Duplication

@punitmundra punitmundra merged commit 932aafc into main Nov 8, 2022
@punitmundra punitmundra deleted the ar/aws_cleanup branch November 8, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants