Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chef-automate gather-logs for faulty nodes #7525

Merged
merged 8 commits into from
Nov 15, 2022
Merged

Conversation

SahithiMy
Copy link
Contributor

@SahithiMy SahithiMy commented Nov 8, 2022

Signed-off-by: SahithiMy sahithi.mylangam@progress.com

🔩 Description: What code changed, and why?

Changed the code for chef-automate gather-logs from sending gather-logs if there is any faulty/inactive nodes.

⛓️ Related Resources

https://chefio.atlassian.net/browse/STALWART-228

👍 Definition of Done

chef-automate gather-logs for frontend and backend nodes
For Frontend nodes

  • if hab is not installed returns error and continues with next node

  • if hab-sup is not running it returns error and continues with next node

  • if deployment-service is not running it will gather logs.
    For backend nodes

  • if hab is not installed returns error and continues with next node

  • if hab-sup is not running it returns error and continues with next node

👟 How to Build and Test the Change

Install this cli in your bastion host:
sahithimy/automate-cli/0.1.0/20221114080320

Run the below command in bastion:
chef-automate gather-logs

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Demo.1.mp4

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
@netlify
Copy link

netlify bot commented Nov 8, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit f7f346e
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63732081c8858600083234e3

@SahithiMy SahithiMy marked this pull request as draft November 8, 2022 12:39
SahithiMy added 4 commits November 9, 2022 17:35
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
@SahithiMy SahithiMy marked this pull request as ready for review November 11, 2022 05:52
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
@Dmaddu
Copy link
Collaborator

Dmaddu commented Nov 14, 2022

@SahithiMy I didn't see any sync between the PR and the corresponding ticket. Does the requirement get modified?
Lets have a discussion on this

Copy link
Collaborator

@Dmaddu Dmaddu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a discussion regarding the changes you have made.

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kalroy kalroy merged commit 3b19331 into main Nov 15, 2022
@kalroy kalroy deleted the sahithi/STALWART-228 branch November 15, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants