Add and delete node command for automate HA #7563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chef-automate ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| @@ -450,3 +441,16 @@ func (e *existingInfra) validateIPs() *list.List { | |||
|
|
|||
| return errorList | |||
| } | |||
|
|
|||
| func readConfig(path string) (ExistingInfraConfigToml, error) { | |||
| templateBytes, err := ioutil.ReadFile(path) | |||
There was a problem hiding this comment.
ioutil.ReadFile is deprecated (Line 446)
Suggested change
| templateBytes, err := ioutil.ReadFile(path) | |
| templateBytes, err := os.ReadFile(path) |
Created by deprecated-ioutil-readfile.
| } | ||
|
|
||
| func writeFile(tomlbytes []byte, filepath string) error { | ||
| err := ioutil.WriteFile(filepath, tomlbytes, 0600) |
There was a problem hiding this comment.
ioutil.WriteFile is deprecated (Line 85)
Suggested change
| err := ioutil.WriteFile(filepath, tomlbytes, 0600) | |
| err := os.WriteFile(filepath, tomlbytes, 0600) |
Created by deprecated-ioutil-writefile.
github-actions
bot
added
the
documentation
vivekshankar1
changed the title
vivekshankar1
changed the title
components/automate-cli/cmd/chef-automate/automateHADeployExistingInfra.go
Outdated
Show resolved
Hide resolved
dishanktiwari2501
approved these changes
Nov 25, 2022
vivekshankar1
force-pushed
the
update_cli_ha_nodes
branch
from
6d1501b
to
e6e020d
Compare
atultherajput
approved these changes
Nov 25, 2022
vivek-yadav
approved these changes
Nov 25, 2022
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
vivekshankar1
force-pushed
the
update_cli_ha_nodes
branch
from
50c10a4
to
9ffc255
Compare
jayvikramsharma1
approved these changes
Nov 25, 2022
|
Kudos, SonarCloud Quality Gate passed! |
kalroy
added
acceptance: verified
acceptance: internal
and removed
acceptance: internal
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Created command to add new node in chef automate HA, example: chef-automate node add --automate 10.0.1.2
Created command to delete node from chef automate HA, example: chef-automate node remove --automate 10.0.1.2
⛓️ Related Resources
https://chefio.atlassian.net/browse/SHIELD-171
https://chefio.atlassian.net/browse/SHIELD-172
👍 Definition of Done
Running the add node command will add node to HA setup
Running the remove node commands will remove node from HA setup.
You can verify this by running
chef-automate statusFollow the docs for add and remove nodes at this link: https://deploy-preview-7563--chef-automate.netlify.app/automate/ha_onprim_deployment_procedure/
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
My.Movie.1.mp4