Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sahithi/STALWART-308 #7641

Merged
merged 9 commits into from
Jan 3, 2023
Merged

sahithi/STALWART-308 #7641

merged 9 commits into from
Jan 3, 2023

Conversation

SahithiMy
Copy link
Contributor

@SahithiMy SahithiMy commented Dec 30, 2022

Signed-off-by: SahithiMy sahithi.mylangam@progress.com

🔩 Description: What code changed, and why?

Deleting the backupID which is already deleted should return the error message and deleting the invalid backupID should return error message.

⛓️ Related Resources

https://chefio.atlassian.net/browse/STALWART-308

👍 Definition of Done

  • Delete the same backup returns the error message
  • Delete the invalid backup shows the error message

👟 How to Build and Test the Change

rebuild components/automate-cli/
chef-automate backup delete BACKUPID

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

demo1.mov

@netlify
Copy link

netlify bot commented Dec 30, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit f2b0df5
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63b3d52396b532000859ab20

@SahithiMy SahithiMy marked this pull request as draft December 30, 2022 09:05
@SahithiMy SahithiMy marked this pull request as ready for review January 2, 2023 06:44
@YashviJain01
Copy link
Collaborator

Backup recording, if the status is completed or in progress

Backup.recording.mov

SahithiMy and others added 7 commits January 3, 2023 11:14
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Yashvi Jain added 2 commits January 3, 2023 11:30
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kalroy kalroy merged commit e5593b7 into main Jan 3, 2023
@kalroy kalroy deleted the sahithi/STALWART-308 branch January 3, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants