Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying unsupported config when isManagedServicesOn #7650

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Conversation

daveaugustus
Copy link
Contributor

@daveaugustus daveaugustus commented Jan 5, 2023

Signed-off-by: Pappu Kumar pappu.kumar@progress.com

🔩 Description: What code changed, and why?

An Automate user should get notified properly when they try to take EFS backup of Automate HA deployed in these scenarios:

  • On Prem deployment with AWS managed DB
  • AWS deployment
  • The command should indicate that EFS backup is not supported with AWS managed DB.

⛓️ Related Resources

👍 Definition of Done

  • The backup command should not error out for On Prem deployment with AWS managed DB to EFS. A corresponding message should be shown informing the reason for failure.
  • The backup command should not error out for AWS deployment to EFS. A corresponding message should be shown informing the reason for failure.
  • The backup command should work for all the other different types of deployments in Automate HA even when backed up to EFS.
  • The backup command should work for AWS deployment and On Prem deployment with AWS managed DB when the backup location is other than EFS.

👟 How to Build and Test the Change

rebuild components/automate-cli/
hab pkg upload results/pappuk-automate-cli-0.1.0-20230105125020-x86_64-linux.hart
Go to bastion and run the following command
hab pkg install pappuk-automate-cli-0.1.0-20230105125020-x86_64-linux.hart -bf
chef-automate backup create

Video of testing:

Screen.Recording.2023-01-05.at.6.26.15.PM.mov

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Jan 5, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 8dcfc37
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63bbe79ff5f2b2000831c7ba
😎 Deploy Preview https://deploy-preview-7650--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@daveaugustus daveaugustus marked this pull request as ready for review January 5, 2023 13:05
@daveaugustus daveaugustus self-assigned this Jan 6, 2023
Pappu Kumar added 4 commits January 6, 2023 12:12
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kalroy kalroy merged commit d2ab942 into main Jan 9, 2023
@kalroy kalroy deleted the STALWART-310 branch January 9, 2023 11:49
@daveaugustus daveaugustus changed the title Displaying unsupported config Displaying unsupported config when isManagedServicesOn Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants