-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displaying unsupported config when isManagedServicesOn #7650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chef-automate ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kalroy
requested changes
Jan 5, 2023
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
daveaugustus
force-pushed
the
STALWART-310
branch
from
January 6, 2023 06:42
450a0dd
to
698d233
Compare
YashviJain01
approved these changes
Jan 9, 2023
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
kalroy
approved these changes
Jan 9, 2023
Kudos, SonarCloud Quality Gate passed! |
daveaugustus
changed the title
Displaying unsupported config
Displaying unsupported config when isManagedServicesOn
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pappu Kumar pappu.kumar@progress.com
🔩 Description: What code changed, and why?
An Automate user should get notified properly when they try to take EFS backup of Automate HA deployed in these scenarios:
⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
rebuild components/automate-cli/
hab pkg upload results/pappuk-automate-cli-0.1.0-20230105125020-x86_64-linux.hart
Go to bastion and run the following command
hab pkg install pappuk-automate-cli-0.1.0-20230105125020-x86_64-linux.hart -bf
chef-automate backup create
Video of testing:
Screen.Recording.2023-01-05.at.6.26.15.PM.mov
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable