ebs volume config is not mandatory in automate ha-managed #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
✅ Deploy Preview for chef-automate ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sahiba3108
requested review from
jayvikramsharma1,
Dmaddu,
vivek-yadav,
ArvinthC3000 and
atultherajput
and removed request for
jayvikramsharma1 and
vivek-yadav
Dmaddu
requested changes
Jan 9, 2023
components/automate-cli/cmd/chef-automate/automateHAAwsDeployment.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
|
Kudos, SonarCloud Quality Gate passed! |
kalroy
approved these changes
Jan 10, 2023
Sahiba3108
changed the title
jayvikramsharma1
approved these changes
Jan 10, 2023
atultherajput
approved these changes
Jan 10, 2023
Dmaddu
approved these changes
Jan 10, 2023
shaik80
pushed a commit
that referenced
this pull request
Jan 23, 2023
* ebs volume config is not mandatory in automate ha-manged Signed-off-by: Sahiba3108 <sgoyal@progress.com> * review changes Signed-off-by: Sahiba3108 <sgoyal@progress.com> Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sahiba3108 sgoyal@progress.com
🔩 Description: What code changed, and why?
As an automate user, when I am doing automate HA deployment with managed services, I should not be forced to enter ebs volumes for pg and os, as it is no longer required.
⛓️ Related Resources
https://chefio.atlassian.net/browse/KINETICS-295
👍 Definition of Done
I have made the required changes, and now you can skip ebs volume configurations in automate HA deployment with managed services.
👟 How to Build and Test the Change
Install this cli:
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Video Link: https://progresssoftware-my.sharepoint.com/:v:/g/personal/sgoyal_progress_com/EdZP9HEvBj1Cs3H1RfyVbAQB0AgHOfpo1ixxS9v6yiXgJw?e=jdkraY
SS after running provisioning cmd: