Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHIELD-229-make-cert-rotate-idempotent #7700

Merged
merged 11 commits into from
Feb 23, 2023

Conversation

prasad927
Copy link
Collaborator

@prasad927 prasad927 commented Feb 2, 2023

Signed-off-by: prasad927 Prasad.Chaudhari@progress.com

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

https://chefio.atlassian.net/browse/SHIELD-229

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

https://progresssoftware.sharepoint.com/:i:/s/ChefCoreC/ES634qGMPVdNkv0GWobHu1sBzWC25gfBCn_uEEZLa3fiJg?e=J1iVYR

https://progresssoftware.sharepoint.com/:i:/s/ChefCoreC/Ebnpo0P4nzxPh663KgIjBcEBCnJhQHg17Qf_uqUZC3LZaQ?e=Jqly8L

https://progresssoftware.sharepoint.com/:i:/s/ChefCoreC/EUh_OJHkqkBFr8PHlGQVkagBBSscyUGVt-DJQs-PlKxuoA?e=QsX8uB

https://progresssoftware.sharepoint.com/:i:/s/ChefCoreC/ERnaeJCeERVNiYaeXTXMPt4BrmNEBrUEU2veNoPu8eIPhg?e=NfcQMw

https://progresssoftware.sharepoint.com/:i:/s/ChefCoreC/ETrEKCDzOzNOhNz6IOwyBpkBaeRicdAlttrv6m7tmt7BcA?e=o4lUVg

https://progresssoftware.sharepoint.com/:i:/s/ChefCoreC/Ec6TOiLhvpJCoKz6Y7N5_GgBavaWxQZ7f6yitaa5Eq9OCQ?e=PYgMe3

@netlify
Copy link

netlify bot commented Feb 2, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 6aac493
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63f4e5823ee10d0008357250

@prasad927 prasad927 self-assigned this Feb 6, 2023
@prasad927 prasad927 changed the title [WIP] SHIELD-229-make-cert-rotate-idempotent SHIELD-229-make-cert-rotate-idempotent Feb 6, 2023
@prasad927 prasad927 changed the title SHIELD-229-make-cert-rotate-idempotent [WIP]SHIELD-229-make-cert-rotate-idempotent Feb 13, 2023
@prasad927 prasad927 changed the title [WIP]SHIELD-229-make-cert-rotate-idempotent SHIELD-229-make-cert-rotate-idempotent Feb 13, 2023
@prasad927 prasad927 force-pushed the SHIELD-229-make-cert-rotate-idempotent branch from 0bf34f8 to 6f530d2 Compare February 15, 2023 09:55
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
@prasad927 prasad927 force-pushed the SHIELD-229-make-cert-rotate-idempotent branch from d633776 to 6aac493 Compare February 21, 2023 15:38
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

38.7% 38.7% Coverage
0.0% 0.0% Duplication

@vivek-yadav vivek-yadav merged commit 8855efc into main Feb 23, 2023
@vivek-yadav vivek-yadav deleted the SHIELD-229-make-cert-rotate-idempotent branch February 23, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants