Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the error log issue #7705

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fixed the error log issue #7705

merged 1 commit into from
Feb 16, 2023

Conversation

GhanavishmathiMacharla
Copy link
Contributor

@GhanavishmathiMacharla GhanavishmathiMacharla commented Feb 6, 2023

Signed-off-by: Ghanavishmathi Macharla gmacharl@progress.com

🔩 Description: What code changed, and why?

Fixed the issue of Node error log data in the Automate UI.
Minor change in resource-item component .html and .ts file to view the node error log data properly.

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-254

👍 Definition of Done

  • Code changes in resource-item component
  • After changes verified the UI

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Issue (before code changes): https://progresssoftware-my.sharepoint.com/:v:/r/personal/ssanju_progress_com/Documents/Chef/Client%20Run%20report%20view,%20search%20by%20filter%20and%20download/Backtrace%20error.mov?csf=1&web=1&e=iyh35B
After:

Screen.Recording.2023-02-06.at.14.15.40.mov

Signed-off-by: Ghanavishmathi Macharla <gmacharl@progress.com>
@netlify
Copy link

netlify bot commented Feb 6, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 042dcdc
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63e08a6253c51300085cee91
😎 Deploy Preview https://deploy-preview-7705--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@arunjn-progress arunjn-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to discuss this change. ResourceId seems to be imperative for the modal window to get details.

@kalroy kalroy merged commit e5ee226 into main Feb 16, 2023
@kalroy kalroy deleted the ghana/KINETICS-254 branch February 16, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants