Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the code for gather-logs #7732

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Modified the code for gather-logs #7732

merged 1 commit into from
Feb 22, 2023

Conversation

SahithiMy
Copy link
Contributor

@SahithiMy SahithiMy commented Feb 20, 2023

🔩 Description: What code changed, and why?

Changed the code for gather-logs, where we are getting gather-logs abruptly stops and does not exit gracefully.

⛓️ Related Resources

https://chefio.atlassian.net/browse/STALWART-345

👍 Definition of Done

Modified the code for gather-logs which stops abruptly.

👟 How to Build and Test the Change

rebuild components/automate-cli/
hab pkg install sahithimy/automate-cli/0.1.0/20230216052302 -bf
chef-automate gather-logs

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screen.Recording.2023-02-20.at.10.05.37.AM.mov

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
@netlify
Copy link

netlify bot commented Feb 20, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit ff40c9d
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63f2fa55dae828000879babc

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kalroy kalroy merged commit aad2a77 into main Feb 22, 2023
@kalroy kalroy deleted the sahithi/STALWART-345 branch February 22, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants