Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for chef Automate navigation loses the chef infra server name from breadcrumb nav bar. #7737

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

vinay033
Copy link
Collaborator

🔩 Description: What code changed, and why?

As an Automate User, When I navigate under Infrastructure / Chef Infra Servers / Organization, the Chef Infra Server Name gets lost from the breadcrumb navigation.

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-147

👍 Definition of Done

I have added some UI changes in the infra proxy module to display the chef server name with a link.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

# build components/automate-ui-devproxy/
# start_automate_ui_background
# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab
--> need to add server first
--> click to server --> you can see the list of org's ---> click to specific org --> you can see the org details page 
check the breadcrumb like the screenshot.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2023-02-22 at 7 56 25 PM

Signed-off-by: vinay sharma <vsharma@chef.io>
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit ef9a79f into main Feb 23, 2023
@kalroy kalroy deleted the Vinay/breadcrumb_nav_bar branch February 23, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants