Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconfigure backup location #7744

Merged
merged 2 commits into from
Feb 27, 2023
Merged

reconfigure backup location #7744

merged 2 commits into from
Feb 27, 2023

Conversation

Sahiba3108
Copy link
Collaborator

@Sahiba3108 Sahiba3108 commented Feb 23, 2023

Signed-off-by: Sahiba3108 (sgoyal@progress.com)

🔩 Description: What code changed, and why?

I want to reconfigure Automate storage location for OpenSearch backup.

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-300

👍 Definition of Done

Reconfigured Automate storage location for OpenSearch backup.

👟 How to Build and Test the Change

Use these packages while creating an Airgap bundle:

  • sahiba3108/automate-cli/0.1.0/20230224065051
  • sahiba3108/deployment-service/0.1.0/20230224073758

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Video Link: https://progresssoftware-my.sharepoint.com/✌️/g/personal/sgoyal_progress_com/EVawQAsYtB5Lh5Whzfi0Fq8B1dinNDFvxtsOGIvufDE-fQ?e=wIgb74

Signed-off-by: Sahiba3108 <sgoyal@progress.com>
@netlify
Copy link

netlify bot commented Feb 23, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit a85fdee
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63f74baa0abe680008e2bd70

Signed-off-by: Sahiba3108 <sgoyal@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

for index in ${indices[@]}; do
curl -XPUT -k -H 'Content-Type: application/json' http://localhost:10144/_snapshot/$index --data-binary @- << EOF
{
"type" : "fs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if user has chosen the s3 bucket ?

Copy link
Collaborator Author

@Sahiba3108 Sahiba3108 Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@punitmundra Then this script will not run, because this is the issue happening with file system only. You can see line no: 106, i have added the condition for file system only.

@punitmundra punitmundra self-requested a review February 27, 2023 14:28
@Dmaddu Dmaddu merged commit 6fb0c61 into main Feb 27, 2023
@Dmaddu Dmaddu deleted the sahiba/reconfigure_backup_location branch February 27, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants