Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IN-898: Fixed infra client run search error suggestion issue #7745

Merged
merged 2 commits into from Feb 24, 2023

Conversation

vaibhavGadre
Copy link
Collaborator

@vaibhavGadre vaibhavGadre commented Feb 23, 2023

πŸ”© Description: What code changed, and why?

Updated Node struct to accept empty error properties in converge.go to update node data in case of success runs.

⛓️ Related Resources

https://chefio.atlassian.net/browse/IN-898
CHEF-358

πŸ‘ Definition of Done

  • Error suggestion not coming for success client runs list and Error filter does not give success client runs.

πŸ‘Ÿ How to Build and Test the Change

rebuild components/ingest-service
start_all_services
  • Add a failure client run data in infrastructure. Check error suggestion.
  • For the same node id, push success client run.
  • verify error suggestion if error shows.

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

infra client run error filter issue

Signed-off-by: Vaibhav Gadre <vaibhavukandrao.gadre@progress.com>
@netlify
Copy link

netlify bot commented Feb 23, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 1474612
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63f88bbc0ffcbb000844ee42

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 5077a97 into main Feb 24, 2023
@kalroy kalroy deleted the vaibhav/IN-898-client-run-error-filter-bug branch February 24, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants