Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compliance graph not showing data of past n days (IN-864) #7748

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

kasif-adnan
Copy link
Collaborator

@kasif-adnan kasif-adnan commented Feb 24, 2023

πŸ”© Description: What code changed, and why?

On first switch to Compliance tab, graph was not populating points for past 10 days, as it should by default. It was only showing for 1 day.
The reason was that api was not being hit with correct start date on first visit. Start date was being calculated correctly on switching tabs( nodes/profiles/controls).

Also, found that the start date was being incorrectly sent for other sections such as node status, node failures.. It should always be one day data and not past n days

⛓️ Related Resources

https://chefio.atlassian.net/browse/IN-864
https://chefio.atlassian.net/browse/CHEF-359

πŸ‘ Definition of Done

fixed the start date to be sent correctly for the API calls.

πŸ‘Ÿ How to Build and Test the Change

On first visit to Compliance Tab , graph should be loaded for past 10 days by default.

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Screen.Recording.2023-02-24.at.3.19.08.PM.mov

Signed-off-by: kasif <kadnan@progress.com>
@netlify
Copy link

netlify bot commented Feb 24, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 653bd30
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63f8e0b550434500083f0b89

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 98662ac into main Feb 28, 2023
@kalroy kalroy deleted the Kasif/IN-864-fix_compliance_graph_not_showing_data branch February 28, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants