Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating button scroll to top issue solved #7791

Merged
merged 2 commits into from
Mar 29, 2023
Merged

floating button scroll to top issue solved #7791

merged 2 commits into from
Mar 29, 2023

Conversation

AadeshNichite
Copy link
Contributor

@AadeshNichite AadeshNichite commented Mar 23, 2023

Signed-off-by: AadeshNichite anichite@progress.com

πŸ”© Description: What code changed, and why?

scroll to top floating button issue solved.

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-1547

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

  1. For local setup just take a branch of code and run it on local machine.
  2. For Ec2 you can just deploy it and check changes.

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Screen.Recording.2023-03-23.at.6.53.11.PM.mov

Signed-off-by: AadeshNichite <54974312+AadeshNichite@users.noreply.github.com>
Signed-off-by: AadeshNichite <54974312+AadeshNichite@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Mar 23, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 3f6d2b3
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/641c55a2e7aa580008d6a238

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 42ed9bd into main Mar 29, 2023
@kalroy kalroy deleted the Aadesh/CHEF-1547 branch March 29, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants