Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for chef-server fqdn #7826

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Changes for chef-server fqdn #7826

merged 2 commits into from
Apr 24, 2023

Conversation

YashviJain01
Copy link
Collaborator

@YashviJain01 YashviJain01 commented Apr 20, 2023

🔩 Description: What code changed, and why?

Need to change the a parameter while connecting workstation with automate ha chef server

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-2687

👍 Definition of Done

Changed the doc

👟 How to Build and Test the Change

Preview link.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit b79672b
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64461ea7f215250008869420
😎 Deploy Preview https://deploy-preview-7826--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Apr 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@YashviJain01 YashviJain01 marked this pull request as ready for review April 21, 2023 05:57
@YashviJain01 YashviJain01 requested a review from a team as a code owner April 21, 2023 05:57
Yashvi Jain added 2 commits April 24, 2023 11:45
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
@Dmaddu Dmaddu merged commit 25376bf into main Apr 24, 2023
@Dmaddu Dmaddu deleted the migration_doc_change branch April 24, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants