Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common output file change to fix add node error #7838

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

ArvinthC3000
Copy link
Collaborator

@ArvinthC3000 ArvinthC3000 commented Apr 24, 2023

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-2775

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

image

@netlify
Copy link

netlify bot commented Apr 24, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit d0ed581
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6449002ca43e680008e2b62b

@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ArvinthC3000 ArvinthC3000 changed the title [WIP]Common output file change to fix add node error Common output file change to fix add node error Apr 25, 2023
@ArvinthC3000 ArvinthC3000 force-pushed the ar/common_output_error branch 3 times, most recently from 18336a4 to 463f8cd Compare April 26, 2023 10:36
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Dmaddu Dmaddu merged commit 9a652af into main Apr 26, 2023
3 checks passed
@Dmaddu Dmaddu deleted the ar/common_output_error branch April 26, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants