Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed waiver control information not showing in details for a control under nodes #7841

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

vinay033
Copy link
Collaborator

🔩 Description: What code changed, and why?

When there is a waived control present and we want to get the details of that control, no expire date, and the reason is showing in the UI.

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-2782

👍 Definition of Done

Added changes to show the expire date, and the reason on waived controls.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

# build components/automate-ui-devproxy/
# start_automate_ui_background
# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab
to test this please add the test data

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • [x ] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2023-04-25 at 5 36 26 PM

Signed-off-by: vinay sharma <vsharma@chef.io>
@netlify
Copy link

netlify bot commented Apr 25, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 95189b2
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6447ef55e477b80008e9b633

@vinay033 vinay033 self-assigned this Apr 25, 2023
@vinay033 vinay033 added compliance reporting This issue or pull request applies to the compliance reporting part of Automate automate-ui labels Apr 25, 2023
Signed-off-by: vinay sharma <vsharma@chef.io>
@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Dmaddu Dmaddu merged commit dabbebc into main Apr 26, 2023
5 checks passed
@Dmaddu Dmaddu deleted the Vinay/CHEF-2782 branch April 26, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-ui compliance reporting This issue or pull request applies to the compliance reporting part of Automate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants