Fix the bug for upgrade flag #7896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing.
|
SahithiMy
force-pushed
the
sahithi/CHEF-1890
branch
from
de20765
to
55c4a5e
Compare
YashviJain01
requested review from
vivekshankar1,
jayvikramsharma1 and
vivek-yadav
punitmundra
approved these changes
May 24, 2023
added 3 commits
May 24, 2023 14:38
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
SahithiMy
force-pushed
the
sahithi/CHEF-1890
branch
from
55c4a5e
to
a84b55d
Compare
|
SonarQube Quality Gate
|
jayvikramsharma1
approved these changes
May 24, 2023
bvtejaswi
pushed a commit
that referenced
this pull request
May 24, 2023
* Fixed the bug for upgrade Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Fix for upgrade Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * updated error msg Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> --------- Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>
punitmundra
reviewed
May 29, 2023
| if err != nil { | ||
| return status.Annotate(err, status.DeployError) | ||
| if frontend { | ||
| err := moveAirgapFrontendBundlesOnlyToTransferDir(airgapMetadata, upgradeRunCmdFlags.airgap) |
There was a problem hiding this comment.
upgradeRunCmdFlags.airgap -> airgapBundlePath
There was a problem hiding this comment.
while testing i found that the value of upgradeRunCmdFlags.airgap is nil, which create the problem while fresh deployment for HA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Fixed the bug for upgrade-frontends flag which is upgrading backend nodes as-well.
⛓️ Related Resources
https://chefio.atlassian.net/browse/CHEF-1890
👍 Definition of Done
Fixed the bug for --upgrade-frontends for upgrade command.
👟 How to Build and Test the Change
rebuild components/automate-clichef-automate upgrade run --airgap-bundle latest.aib --upgrade-frontends✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Before upgrade
After upgrade
