-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix chef-automate test command exit error and ha cert doc update #7898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chef-automate ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vivek-yadav
reviewed
May 19, 2023
# public_key = "" | ||
# Add Automate load balancer root-ca and keys | ||
# root_ca = """root_ca_contents""" | ||
# private_key = """private_key_contents""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# private_key = """private_key_contents""" | |
## Private and Public keys are only needed if self generated certs are used for Automate Nodes. | |
# private_key = """private_key_contents""" |
1c8d00c
to
d4d54e2
Compare
punitmundra
approved these changes
May 22, 2023
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
d4d54e2
to
7d1e78a
Compare
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>
dishanktiwari2501
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the possible changes directly to the PR.
Hence, approving!
vivek-yadav
approved these changes
May 30, 2023
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
YashviJain01
pushed a commit
that referenced
this pull request
Jun 14, 2023
* fix automate test command Signed-off-by: Vivek Shankar <vshankar@progress.com> * doc changes for ha certificates Signed-off-by: Vivek Shankar <vshankar@progress.com> * changes for lb root ca Signed-off-by: Vivek Shankar <vshankar@progress.com> * added pages for rds and os Signed-off-by: Vivek Shankar <vshankar@progress.com> * added page tags Signed-off-by: Vivek Shankar <vshankar@progress.com> * small formatting Signed-off-by: Vivek Shankar <vshankar@progress.com> * small changes Signed-off-by: Vivek Shankar <vshankar@progress.com> * formatted Signed-off-by: Vivek Shankar <vshankar@progress.com> * typo Signed-off-by: Vivek Shankar <vshankar@progress.com> * updates create pg os references Signed-off-by: Vivek Shankar <vshankar@progress.com> * updated link Signed-off-by: Vivek Shankar <vshankar@progress.com> * updated link Signed-off-by: Vivek Shankar <vshankar@progress.com> * updated link Signed-off-by: Vivek Shankar <vshankar@progress.com> * updated title Signed-off-by: Vivek Shankar <vshankar@progress.com> * updated version Signed-off-by: Vivek Shankar <vshankar@progress.com> * aws doc link Signed-off-by: Vivek Shankar <vshankar@progress.com> * added more Signed-off-by: Vivek Shankar <vshankar@progress.com> * added more Signed-off-by: Vivek Shankar <vshankar@progress.com> * added small change Signed-off-by: Vivek Shankar <vshankar@progress.com> * added small change Signed-off-by: Vivek Shankar <vshankar@progress.com> * added small change Signed-off-by: Vivek Shankar <vshankar@progress.com> * added small change Signed-off-by: Vivek Shankar <vshankar@progress.com> * link changes Signed-off-by: Vivek Shankar <vshankar@progress.com> * add export to infra restore Signed-off-by: Vivek Shankar <vshankar@progress.com> * add export to infra restore Signed-off-by: Vivek Shankar <vshankar@progress.com> * self managed pg text Signed-off-by: Vivek Shankar <vshankar@progress.com> * made some formattting changes Signed-off-by: dishanktiwari2501 <dtiwari@progress.com> * change heading and format Signed-off-by: Vivek Shankar <vshankar@progress.com> --------- Signed-off-by: Vivek Shankar <vshankar@progress.com> Signed-off-by: dishanktiwari2501 <dtiwari@progress.com> Co-authored-by: dishanktiwari2501 <dtiwari@progress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
init-config-ha
template for certificateschef-automate test
command not exiting gracefully error.⛓️ Related Resources
https://chefio.atlassian.net/browse/CHEF-3216
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable