Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config copy issue #7942

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Fix config copy issue #7942

merged 3 commits into from
Jun 5, 2023

Conversation

shanmugapriya-tr
Copy link
Collaborator

@shanmugapriya-tr shanmugapriya-tr commented Jun 2, 2023

πŸ”© Description: What code changed, and why?

Introduced InputFilePrefix - to hold the formatted file name to be used everywhere

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-3217

πŸ‘ Definition of Done

User should be able to patch config present in any folder path

πŸ‘Ÿ How to Build and Test the Change

Checkout the branch
rebuild components/automate-cli

use the package to test changes

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Screenshot 2023-06-05 at 8 55 56 PM Screenshot 2023-06-05 at 8 55 33 PM Screenshot 2023-06-05 at 8 55 15 PM Screenshot 2023-06-05 at 8 53 46 PM Screenshot 2023-06-05 at 3 34 50 PM Screenshot 2023-06-05 at 3 36 18 PM

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>
Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>
@netlify
Copy link

netlify bot commented Jun 2, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 6f5f6ab
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/647dfa53cb89e00008240cff

Signed-off-by: Shanmugapriya <shramana@progress.com>
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate failed

Failed condition 50.0% 50.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@kalroy kalroy merged commit d244c1f into main Jun 5, 2023
5 of 7 checks passed
@kalroy kalroy deleted the fix-config-copy-issue branch June 5, 2023 16:08
YashviJain01 pushed a commit that referenced this pull request Jun 14, 2023
* fix file used in config Cmd

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>

* fix automate config prefix

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>

* Review comment

Signed-off-by: Shanmugapriya <shramana@progress.com>

---------

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
Co-authored-by: Vivek Yadav <vivek.yadav@progress.com>
bvtejaswi pushed a commit that referenced this pull request Jun 14, 2023
* fix file used in config Cmd

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>

* fix automate config prefix

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>

* Review comment

Signed-off-by: Shanmugapriya <shramana@progress.com>

---------

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
Co-authored-by: Vivek Yadav <vivek.yadav@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants