Infrastructure command on bastion of Automate HA cluster for node delete #7944

Sunanda-Boorla · 2023-06-05T04:34:19Z

🔩 Description: What code changed, and why?

As a user of Automate HA, when I run chef-automate infrastructure and chef-automate infrastructure node-delete command on bastion system of Automate HA cluster, I should see output relevant to Automate HA infrastructure

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

git checkout this branch
rebuild components/automate-cli and upload it to you origin
Install automate-cli on bastion
Add nodes using load test suite.
Run chef-automate infrastructure node-delete <node-id>

✅ Checklist

All PRs must tick these:

I have read the CONTRIBUTING document.
All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

Tests added/updated? (all new code needs new tests)
Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

https://progresssoftware-my.sharepoint.com/:v:/g/personal/sboorla_progress_com/EdckQQBzYG1JkOtsf6qNp1oBXXJL0dztWa7PyEpcvJamAw?e=gzoFdo

https://progresssoftware-my.sharepoint.com/:v:/g/personal/sboorla_progress_com/EZln7QaOTvZEtQfgbPvGozEBqXmFWxKsXNvtYRc3KKKIVA?e=Pplfba

https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/ESdkFe-54vFPo-13qc-i1CQBvmUmQQfLdQmypLemy7J2oA?e=YKwNAu

netlify · 2023-06-05T04:34:24Z

👷 Deploy Preview for chef-automate processing.

Name	Link
🔨 Latest commit	`e2b5b9f`
🔍 Latest deploy log	https://app.netlify.com/sites/chef-automate/deploys/648811376429ca0007490372

jayvikramsharma1 · 2023-06-12T10:40:49Z

components/automate-cli/cmd/chef-automate/infrastructure_test.go

+	}
+	for _, tt := range tests {
+		t.Run(tt.testName, func(t *testing.T) {
+			if err := runDeleteNodeCmd(tt.cmd, tt.args); (err != nil) != tt.wantErr {


condition is unnecessarily complex and the if condition also doesn't look correct, please simplify the conditions

jayvikramsharma1 · 2023-06-12T10:40:56Z

components/automate-cli/cmd/chef-automate/infrastructure_test.go

+			}
+		})
+		t.Run(tt.testName, func(t *testing.T) {
+			if err := preInfrastructureCmd(tt.cmd, tt.args); (err != nil) != tt.wantErr {


condition is unnecessarily complex and the condition also doesn't look correct, please simplify the conditions

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

Signed-off-by: sandhi <sagarwal@progress.com>

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

Signed-off-by: sandhi <sagarwal@progress.com>

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

sonarqube-for-infrastructure-prod · 2023-06-13T07:13:49Z

SonarQube Quality Gate

61.1% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

…ete (#7944) * Infrastructure command on bastion Signed-off-by: Sunanda-Boorla <sboorla@progress.com> * Infrastructure command on bastion Signed-off-by: Sunanda-Boorla <sboorla@progress.com> * infrastructure command Signed-off-by: Sunanda-Boorla <sboorla@progress.com> * Changes to increase the coverage Signed-off-by: sandhi <sagarwal@progress.com> * changes for coverage increase Signed-off-by: sandhi <sagarwal@progress.com> * Increasing code coverage Signed-off-by: Sunanda-Boorla <sboorla@progress.com> * Reverting the node-delete change Signed-off-by: Sunanda-Boorla <sboorla@progress.com> * Changes for test case failure Signed-off-by: sandhi <sagarwal@progress.com> * Revert doc changes Signed-off-by: sandhi <sagarwal@progress.com> * changes for test case failure Signed-off-by: Sunanda-Boorla <sboorla@progress.com> * changes for test case failure Signed-off-by: Sunanda-Boorla <sboorla@progress.com> * changes for test case failure Signed-off-by: Sunanda-Boorla <sboorla@progress.com> * Formatting Signed-off-by: Sunanda-Boorla <sboorla@progress.com> --------- Signed-off-by: Sunanda-Boorla <sboorla@progress.com> Signed-off-by: sandhi <sagarwal@progress.com> Co-authored-by: Sunanda-Boorla <sboorla@progress.com> Co-authored-by: sandhi <sagarwal@progress.com>

Sunanda-Boorla changed the title ~~[WIP] Infrastructure command on bastion~~ [WIP] Infrastructure command on bastion of Automate HA cluster Jun 5, 2023

Sunanda-Boorla requested a review from a team as a code owner June 5, 2023 06:15

github-actions bot added the documentation Anything related to the Automate docs. label Jun 5, 2023

sandhi18 force-pushed the CHEF-708-infrastructure-command branch from 2972a32 to 47918b1 Compare June 6, 2023 11:27

sandhi18 changed the title ~~[WIP] Infrastructure command on bastion of Automate HA cluster~~ Infrastructure command on bastion of Automate HA cluster for node delete Jun 7, 2023

sandhi18 requested review from vivek-yadav, rishabhjhs, atultherajput, jayvikramsharma1, ArvinthC3000, vivekshankar1, vviveksharma, karunesh-tech, vipin230, bvtejaswi and punitmundra June 7, 2023 12:45

jayvikramsharma1 requested changes Jun 12, 2023

View reviewed changes

sandhi18 requested a review from jayvikramsharma1 June 13, 2023 05:51

github-actions bot removed the documentation Anything related to the Automate docs. label Jun 13, 2023

Sunanda-Boorla and others added 10 commits June 13, 2023 11:39

Infrastructure command on bastion

a12d039

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

Infrastructure command on bastion

010ed65

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

infrastructure command

64abed6

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

Changes to increase the coverage

5abd266

Signed-off-by: sandhi <sagarwal@progress.com>

changes for coverage increase

a483c5b

Signed-off-by: sandhi <sagarwal@progress.com>

Increasing code coverage

de332ee

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

Reverting the node-delete change

d5ef099

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

Changes for test case failure

aebf830

Signed-off-by: sandhi <sagarwal@progress.com>

Revert doc changes

bfe54a4

Signed-off-by: sandhi <sagarwal@progress.com>

changes for test case failure

2169b11

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

Sunanda-Boorla force-pushed the CHEF-708-infrastructure-command branch from 505684a to 2169b11 Compare June 13, 2023 06:09

Sunanda-Boorla added 3 commits June 13, 2023 11:55

changes for test case failure

62a1a50

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

changes for test case failure

93f7acb

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

Formatting

e2b5b9f

Signed-off-by: Sunanda-Boorla <sboorla@progress.com>

vivekshankar1 approved these changes Jun 13, 2023

View reviewed changes

rishabhjhs approved these changes Jun 13, 2023

View reviewed changes

punitmundra approved these changes Jun 13, 2023

View reviewed changes

vipin230 approved these changes Jun 13, 2023

View reviewed changes

punitmundra merged commit fd8b726 into main Jun 13, 2023
5 of 8 checks passed

punitmundra deleted the CHEF-708-infrastructure-command branch June 13, 2023 09:39

prasad927 approved these changes Jun 13, 2023

View reviewed changes

ArvinthC3000 approved these changes Jun 13, 2023

View reviewed changes

vviveksharma approved these changes Jun 13, 2023

View reviewed changes

kalroy added the add_release_notes label Aug 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Infrastructure command on bastion of Automate HA cluster for node delete #7944

Infrastructure command on bastion of Automate HA cluster for node delete #7944

Sunanda-Boorla commented Jun 5, 2023 •

edited

netlify bot commented Jun 5, 2023 •

edited

jayvikramsharma1 Jun 12, 2023

Sunanda-Boorla Jun 13, 2023

jayvikramsharma1 Jun 12, 2023

Sunanda-Boorla Jun 13, 2023

sonarqube-for-infrastructure-prod bot commented Jun 13, 2023

Infrastructure command on bastion of Automate HA cluster for node delete #7944

Infrastructure command on bastion of Automate HA cluster for node delete #7944

Conversation

Sunanda-Boorla commented Jun 5, 2023 • edited

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

📷 Screenshots, if applicable

netlify bot commented Jun 5, 2023 • edited

👷 Deploy Preview for chef-automate processing.

jayvikramsharma1 Jun 12, 2023

Choose a reason for hiding this comment

Sunanda-Boorla Jun 13, 2023

Choose a reason for hiding this comment

jayvikramsharma1 Jun 12, 2023

Choose a reason for hiding this comment

Sunanda-Boorla Jun 13, 2023

Choose a reason for hiding this comment

sonarqube-for-infrastructure-prod bot commented Jun 13, 2023

Sunanda-Boorla commented Jun 5, 2023 •

edited

netlify bot commented Jun 5, 2023 •

edited