Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support cert by ip for aws #7945

Merged
merged 16 commits into from
Jul 3, 2023
Merged

support cert by ip for aws #7945

merged 16 commits into from
Jul 3, 2023

Conversation

shaik80
Copy link
Member

@shaik80 shaik80 commented Jun 5, 2023 •
edited
Loading

🔩 Description: What code changed, and why?

need to support cert by ip on aws deployment

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-2297

👍 Definition of Done

👟 How to Build and Test the Change

following test is done on Aws deployment

  • upgrade from curent version to latest changes
    steps
    1. use curent cli to do provision
    2. deploy
    3. cert rotate for all service a2/cs/pg/os
    4. upgrade to latest changes
    5. cert show (to see cert is reverted back or not)

  • upgrade from latest changes another version
    steps
    1. use latest change cli to do provision
    2. deploy
    3. cert rotate for all service a2/cs/pg/os
    4. upgrade to latest changes
    5. cert show (to see cert is reverted back or not)

  • add node
    steps
    1. add node
    2. cert show (to see cert is reverted back or not)

  • delete node
    steps
    1. delete node
    2. cert show (to see cert is reverted back or not)

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Jun 5, 2023 •
edited
Loading

✅ Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 3969ec6
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64a280136178560008736f62
😎 Deploy Preview https://deploy-preview-7945--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shaik80 shaik80 force-pushed the CHEF-2297-implement-optional-cert-by-ip-by-ip-for-aws-deployment-also branch from 0ca3a3e to 0039acd Compare June 22, 2023 10:26
@vivekshankar1 vivekshankar1 self-requested a review June 22, 2023 16:49
ArvinthC3000
ArvinthC3000 reviewed Jun 23, 2023
View reviewed changes
components/automate-cli/cmd/chef-automate/automateHAAwsDeployment.go
type awsDeployment struct {
config AwsConfigToml
configPath string
AWSConfigIp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declare the type

ArvinthC3000
ArvinthC3000 reviewed Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@ArvinthC3000 ArvinthC3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the custom cert flow in On-Prem and make suer this change is not braking On-Prem flow

@vivekshankar1
Copy link
Collaborator

Fix verify pipeline

@shaik80 shaik80 requested a review from a team as a code owner June 23, 2023 09:29
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Jun 23, 2023
@shaik80 shaik80 force-pushed the CHEF-2297-implement-optional-cert-by-ip-by-ip-for-aws-deployment-also branch from bcc70f9 to 36de80d Compare June 26, 2023 12:26
@shaik80 shaik80 force-pushed the CHEF-2297-implement-optional-cert-by-ip-by-ip-for-aws-deployment-also branch from e6beffa to c4e5ce9 Compare June 28, 2023 14:29
@shaik80 @vivekshankar1
apply for ip_cert for aws
692b801 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
complete changes cert_by_ip
5783698 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
request changes
7faa8c9 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
request changes
b97078e 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
doc changes
bd46954 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
request changes
b955789 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
shaik80 and others added 10 commits July 3, 2023 13:26
@shaik80 @vivekshankar1
fix pipline
b3a4fd7 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
remove common config from aws.auto.tfvar during upgrade and hide comm…
2e9c022 
…on config during provision

Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
remove content from aws outo tfvar
8a5380f 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
revert back origin
6fc2aaf 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
don't add common config during add or delete node
cb84560 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
set arc before deploy after provision
95ad5c0 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
test improve
74ce4c1 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 @vivekshankar1
unit test improve
de5aff6 
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@vivekshankar1
fixed bugs
9f296d5 
Signed-off-by: Vivek Shankar <vshankar@progress.com>
@vivekshankar1
fixed confi\licts
3969ec6 
Signed-off-by: Vivek Shankar <vshankar@progress.com>
@vivekshankar1 vivekshankar1 force-pushed the CHEF-2297-implement-optional-cert-by-ip-by-ip-for-aws-deployment-also branch from aab1576 to 3969ec6 Compare July 3, 2023 08:00
@sonarqube-for-infrastructure-prod
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 19.9% 19.9% Coverage on New Code (is less than 80%)
Failed condition 17.0% 16.97% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@vivek-yadav vivek-yadav merged commit 174958d into main Jul 3, 2023
5 of 7 checks passed
@vivek-yadav vivek-yadav deleted the CHEF-2297-implement-optional-cert-by-ip-by-ip-for-aws-deployment-also branch July 3, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArvinthC3000 ArvinthC3000 ArvinthC3000 left review comments

@bvtejaswi bvtejaswi bvtejaswi left review comments

@vivek-yadav vivek-yadav vivek-yadav approved these changes

@vivekshankar1 vivekshankar1 vivekshankar1 approved these changes

@punitmundra punitmundra Awaiting requested review from punitmundra

Assignees

@shaik80 shaik80

Labels
add_release_notes documentation Anything related to the Automate docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shaik80 @vivekshankar1 @vivek-yadav @ArvinthC3000 @bvtejaswi @kalroy