Allowing Restart-Services from bastion #7958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing.
|
github-actions
bot
added
the
documentation
bvtejaswi
force-pushed
the
restart-from-bastion
branch
from
15c3be0
to
5ac57ac
Compare
github-actions
bot
removed
the
documentation
bvtejaswi
changed the title
bvtejaswi
requested review from
vivek-yadav,
rishabhjhs,
atultherajput,
sandhi18,
jayvikramsharma1,
punitmundra,
shaik80,
ArvinthC3000,
vivekshankar1,
vviveksharma,
prasad927,
karunesh-tech,
vipin230 and
Sunanda-Boorla
bvtejaswi
force-pushed
the
restart-from-bastion
branch
from
5ac57ac
to
9a524b0
Compare
Sunanda-Boorla
approved these changes
Jun 15, 2023
Comment on lines
122
to
124
| remoteExecutor := NewRemoteCmdExecutor(nodemap, sshUtil, writer) | ||
| cmdResult, err := remoteExecutor.Execute() | ||
| return cmdResult, err |
There was a problem hiding this comment.
Instead of creating a new instance you can store an instance of remoteExecutor in the restartFromBastionImpl struct while you are initialising it.
This will reduce the initialisation overhead of remoteExecutor when you are calling executeRemoteExecutor multiple times in your code
There was a problem hiding this comment.
You can use ExecuteWithNodeMap for you use case
Comment on lines
128
to
135
| mutex.Lock() | ||
| writer.Printf("=====================================================\n") | ||
| for _, value := range cmdResult { | ||
| for _, cmdResult := range value { | ||
| printOutput(remoteService, *cmdResult, []string{}, writer) | ||
| } | ||
| } | ||
| mutex.Unlock() |
There was a problem hiding this comment.
mutex may work, but its unnecessary for your use case same could be achieved by channels too
Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>
Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>
rishabhjhs
reviewed
Jun 19, 2023
rishabhjhs
reviewed
Jun 19, 2023
rishabhjhs
reviewed
Jun 19, 2023
Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>
vviveksharma
approved these changes
Jun 19, 2023
punitmundra
approved these changes
Jun 19, 2023
rishabhjhs
approved these changes
Jun 19, 2023
shaik80
approved these changes
Jun 19, 2023
Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>
Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>
prasad927
reviewed
Jun 20, 2023
punitmundra
approved these changes
Jun 20, 2023
atultherajput
approved these changes
Jun 20, 2023
Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>
ArvinthC3000
approved these changes
Jun 20, 2023
|
SonarQube Quality Gate
|
prasad927
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
As a user of Automate HA, when I run following commands on bastion system of Automate HA cluster, I should see output relevant to Automate HA infrastructure:
chef-automate restart-services
⛓️ Related Resources
https://chefio.atlassian.net/browse/CHEF-720
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Demo-video