Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stop command #7966

Merged
merged 5 commits into from Jun 19, 2023
Merged

add stop command #7966

merged 5 commits into from Jun 19, 2023

Conversation

Sahiba3108
Copy link
Collaborator

@Sahiba3108 Sahiba3108 commented Jun 15, 2023

🔩 Description: What code changed, and why?

Added stop command for HA which can be run from bastion node to stop the services of automate, chef_server, postgresql, opensearch.

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-712

👍 Definition of Done

Added stop command for HA which can be run from bastion node to stop the services of automate, chef_server, postgresql, opensearch. You can also provide any particular ip of which you want to stop the services.

Tested on Standalone Automate, Dev Mode and HA deployments.

👟 How to Build and Test the Change

Install this cli package: sahiba3108/automate-cli/0.1.0/20230615120402
Then you can run stop command. Some of the examples are:

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2023-06-15 at 5 38 06 PM Screenshot 2023-06-15 at 3 12 15 PM Screenshot 2023-06-15 at 3 12 28 PM Screenshot 2023-06-15 at 3 12 45 PM Screenshot 2023-06-15 at 3 12 56 PM Screenshot 2023-06-15 at 3 13 12 PM Screenshot 2023-06-15 at 3 13 34 PM Screenshot 2023-06-15 at 5 40 32 PM Screenshot 2023-06-15 at 3 14 58 PM Screenshot 2023-06-15 at 3 17 50 PM Screenshot 2023-06-15 at 4 10 11 PM Screenshot 2023-06-15 at 4 09 58 PM Screenshot 2023-06-15 at 5 37 32 PM

@netlify
Copy link

netlify bot commented Jun 15, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 3344c7b
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/649098e2b1b8f9000856b8ec

@Sahiba3108 Sahiba3108 self-assigned this Jun 15, 2023
@Sahiba3108 Sahiba3108 requested a review from a team as a code owner June 15, 2023 11:21
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Jun 15, 2023
@YashviJain01
Copy link
Collaborator

Please test it on standalone automate and in dev mode as well

@Sahiba3108
Copy link
Collaborator Author

Tested on Standalone and Dev Mode as well. Working fine @YashviJain01
Screenshot 2023-06-16 at 2 15 31 PM
Screenshot 2023-06-16 at 2 16 18 PM

Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
@Dmaddu Dmaddu force-pushed the sahiba/chef712-stop-command branch from b74c355 to 3344c7b Compare June 19, 2023 18:05
@Dmaddu Dmaddu merged commit a94b9b8 into main Jun 19, 2023
5 of 7 checks passed
@Dmaddu Dmaddu deleted the sahiba/chef712-stop-command branch June 19, 2023 18:23
@sonarqube-for-infrastructure-prod

iamazzeez pushed a commit that referenced this pull request Jun 20, 2023
* add stop command

Signed-off-by: Sahiba3108 <sgoyal@progress.com>

* update documentation for stop command

Signed-off-by: Sahiba3108 <sgoyal@progress.com>

* fix code smell

Signed-off-by: Sahiba3108 <sgoyal@progress.com>

* fix pipeline

Signed-off-by: Sahiba3108 <sgoyal@progress.com>

* add constant for stop command

Signed-off-by: Sahiba3108 <sgoyal@progress.com>

---------

Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add_release_notes documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants