Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make es-sidecar-service config respect cfg.backups.backend #7976

Merged
merged 1 commit into from Jul 4, 2023

Conversation

mskdenigma
Copy link
Contributor

🔩 Description: What code changed, and why?

I added a check for cfg.backups.backend in the es-sidecar-service config template so that if we have that configuration set globally it will respect it. Currently the conditional statement checks only checks for this configuration IF we are using the internal automate-opensearch service.

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Emir Rios <erios@etsy.com>
@netlify
Copy link

netlify bot commented Jun 20, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 9b4accf
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6491e9c677b1c6000859ba61

@nrgetik
Copy link
Contributor

nrgetik commented Jun 21, 2023

@chef/automate-team this could be interesting to you

@vivek-yadav
Copy link
Collaborator

Thanks @mskdenigma for the PR, we will get this Reviewed and Tested by next week.

Copy link
Collaborator

@vivekshankar1 vivekshankar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@vivek-yadav vivek-yadav merged commit 1181ccc into chef:main Jul 4, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants