Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for proxy_ssl_server_name to automate-es-gateway #7984

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

mskdenigma
Copy link
Contributor

πŸ”© Description: What code changed, and why?

When connecting to external Opensearch clusters they may be configured in a way that requires passing along the hostname via the http request. One example of this is Opensearch hosted in Kubernetes which is using a shared ingress that depends on the hostname to be passed for internal routing to the correct service. This code updates the config api to support a new boolean value AND updates the nginx config for automate-es-gateway to check for this config value to determine whether or not to set proxy_ssl_server_name on;

⛓️ Related Resources

πŸ‘ Definition of Done

You should be able to set or patch in this config:

[esgateway.v1.sys.ngx.http]
proxy_ssl_server_name = true

and the nginx.conf for automate-es-gateway should include the line

proxy_ssl_server_name on;

πŸ‘Ÿ How to Build and Test the Change

I need help testing this as attempting to run the dev environment even on the main branch with no changes is failing for me.

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: Emir Rios <erios@etsy.com>
@netlify
Copy link

netlify bot commented Jun 22, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit ea4b9cf
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64a44e550810e1000835a822

@nrgetik
Copy link
Contributor

nrgetik commented Jun 22, 2023

fyi @chef/automate-team

@vivek-yadav
Copy link
Collaborator

Thanks @mskdenigma for the PR, we will get it Reviewed and Tested by next week.

@vivek-yadav vivek-yadav merged commit a48ca60 into chef:main Jul 5, 2023
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants