Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerating the automate-dex build #8007

Merged
merged 1 commit into from
Jul 11, 2023
Merged

regenerating the automate-dex build #8007

merged 1 commit into from
Jul 11, 2023

Conversation

Dmaddu
Copy link
Collaborator

@Dmaddu Dmaddu commented Jun 28, 2023

https://chefio.atlassian.net/browse/CHEF-3715

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

@netlify
Copy link

netlify bot commented Jun 28, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 1602aea
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64ad310c4037450007e3720e

@Dmaddu Dmaddu marked this pull request as ready for review June 28, 2023 14:12
@Dmaddu Dmaddu requested a review from kalroy June 28, 2023 14:12
@Dmaddu Dmaddu requested a review from iamazzeez July 11, 2023 10:32
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Copy link
Contributor

@iamazzeez iamazzeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with all types of logins Local, LDAP and SAML.

@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Dmaddu Dmaddu merged commit 8bdb557 into main Jul 11, 2023
6 of 8 checks passed
@Dmaddu Dmaddu deleted the CHEF-3715 branch July 11, 2023 11:48
bvtejaswi pushed a commit that referenced this pull request Jul 17, 2023
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants