Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provision AWS LB should have an option to choose the Private subnet #8062

Conversation

atultherajput
Copy link
Member

@atultherajput atultherajput commented Jul 12, 2023

πŸ”© Description: What code changed, and why?

Made public subnet optional in config.toml

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-3646

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

Use Package: akrishna/automate-ha-deployment/0.1.0/20230718130731

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Screenshot 2023-07-21 at 7 32 48 PM

Demo: https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/EdNK_u6VKlJHo23cpq6GKwIBgbqSUH5M7v8bzYIpsw1tVg?e=cFbIec

@atultherajput atultherajput self-assigned this Jul 12, 2023
@netlify
Copy link

netlify bot commented Jul 12, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 492068e
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64b68e93c684c30008a4e286

@atultherajput atultherajput marked this pull request as ready for review July 12, 2023 21:23
@atultherajput atultherajput force-pushed the CHEF-3646-provision-aws-lb-should-have-an-option-to-choose-the-private-subnet branch from 98d2593 to 0033ffb Compare July 17, 2023 15:30
@atultherajput atultherajput requested a review from a team July 17, 2023 17:16
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput atultherajput force-pushed the CHEF-3646-provision-aws-lb-should-have-an-option-to-choose-the-private-subnet branch from 2f56278 to 16d1df0 Compare July 18, 2023 11:35
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@atultherajput atultherajput removed the WIP label Jul 21, 2023
@vivek-yadav vivek-yadav merged commit 441954f into main Jul 21, 2023
6 of 8 checks passed
@vivek-yadav vivek-yadav deleted the CHEF-3646-provision-aws-lb-should-have-an-option-to-choose-the-private-subnet branch July 21, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants