Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Remove Node Fix #8070

Merged
merged 1 commit into from Jul 20, 2023
Merged

AWS Remove Node Fix #8070

merged 1 commit into from Jul 20, 2023

Conversation

SanjuPal01
Copy link
Collaborator

@SanjuPal01 SanjuPal01 commented Jul 19, 2023

🔩 Description: What code changed, and why?

We have an automate array like [a, b, c, d]
If we remove the node b, it deletes the node b, it deletes the node d and then it creates a fresh machine in place of node b
This is unexpected behaviour since we did not want to do anything to node d

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-3630

👍 Definition of Done

rebuild components/automate-backend-deployment package
OR
use this package: ssanju/automate-ha-deployment/0.1.0/20230719095316

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Video Link: https://progresssoftware-my.sharepoint.com/:v:/g/personal/ssanju_progress_com/EdSY_F9H_BpHsVn7pP_nu_0BuJbdhLDNkVzOn3bcXrYxVA?e=AfKeva

Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>
@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 52f4556
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64b7cca21b63e600087030f2
😎 Deploy Preview https://deploy-preview-8070--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SanjuPal01 SanjuPal01 marked this pull request as ready for review July 20, 2023 14:36
@vivek-yadav vivek-yadav merged commit 27e3755 into main Jul 20, 2023
6 of 8 checks passed
@vivek-yadav vivek-yadav deleted the sanju/remove_node_fix branch July 20, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants