New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating config-gen and error messages #8122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chef-automate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ArvinthC3000
requested review from
vivek-yadav,
jayvikramsharma1,
punitmundra and
bvtejaswi
August 10, 2023 15:02
ArvinthC3000
changed the title
[WIP]Updating config-gen and error messages
Updating config-gen and error messages
Aug 16, 2023
ArvinthC3000
force-pushed
the
ar/config-gen-update_5540
branch
from
August 17, 2023 07:10
2dd3b2a
to
1acc978
Compare
bvtejaswi
approved these changes
Aug 18, 2023
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
ArvinthC3000
force-pushed
the
ar/config-gen-update_5540
branch
from
August 18, 2023 08:45
1acc978
to
a67df35
Compare
punitmundra
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
IAM role:
When the IAM role is attached to the bastion, the user should able to use IAM role instead of IAM User credentials
prompt to create snapshot credentials
Config gen update
⛓️ Related Resources
Jira: https://chefio.atlassian.net/browse/CHEF-4734
https://chefio.atlassian.net/browse/CHEF-5511
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Demo Video
Error message:
IAM role prompt:
Prompt to create snapshot cred
Use existing credentials: