Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating config-gen and error messages #8122

Merged
merged 6 commits into from Aug 23, 2023
Merged

Conversation

ArvinthC3000
Copy link
Collaborator

@ArvinthC3000 ArvinthC3000 commented Aug 10, 2023

🔩 Description: What code changed, and why?

IAM role:

  • When the IAM role is attached to the bastion, the user should able to use IAM role instead of IAM User credentials

  • prompt to create snapshot credentials

Config gen update

  • Update the regex error with the sample pattern in the text label
  • gen prompt should show that the subnet id should be added when the user chooses to provide to subnets
  • Showing sample values in Label wherever necessary

⛓️ Related Resources

Jira: https://chefio.atlassian.net/browse/CHEF-4734
https://chefio.atlassian.net/browse/CHEF-5511

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Demo Video

image

Error message:
image

IAM role prompt:
image

Prompt to create snapshot cred
image

Use existing credentials:
image

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit a67df35
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64df2fa04489bd00089cfaed
😎 Deploy Preview https://deploy-preview-8122--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ArvinthC3000 ArvinthC3000 changed the title [WIP]Updating config-gen and error messages Updating config-gen and error messages Aug 16, 2023
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate failed

0.0% 0.0% Security Hotspots Reviewed on New Code (is less than 100%)

See analysis details on SonarQube

@punitmundra punitmundra merged commit 43e392d into main Aug 23, 2023
5 of 8 checks passed
@punitmundra punitmundra deleted the ar/config-gen-update_5540 branch August 23, 2023 05:24
@ArvinthC3000 ArvinthC3000 self-assigned this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants