Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jay/chef 4487 #8123

Merged
merged 4 commits into from Aug 17, 2023
Merged

Jay/chef 4487 #8123

merged 4 commits into from Aug 17, 2023

Conversation

jayvikramsharma1
Copy link
Collaborator

🔩 Description: What code changed, and why?

As an automate HA user I may need to have a validation of config before deployment or upgrade, We have config verify in place, we will be integrating the same in Automate HA deployment and upgrade

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-4487

👍 Definition of Done

Dev tested

👟 How to Build and Test the Change

build automate-cli module

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 972a40e
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64ddae3a4302290008138d9f
😎 Deploy Preview https://deploy-preview-8123--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jayvikramsharma1 jayvikramsharma1 changed the title Jay/chef 4487 [WIP]Jay/chef 4487 Aug 11, 2023
@jayvikramsharma1 jayvikramsharma1 changed the title [WIP]Jay/chef 4487 Jay/chef 4487 Aug 14, 2023
Copy link
Collaborator

@punitmundra punitmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the test coverage

Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate failed

Failed condition 19.7% 19.7% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@punitmundra punitmundra merged commit ef37dea into main Aug 17, 2023
5 of 8 checks passed
@punitmundra punitmundra deleted the jay/chef-4487 branch August 17, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants