Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fqdn check wait time #8144

Merged
merged 1 commit into from Aug 22, 2023
Merged

fqdn check wait time #8144

merged 1 commit into from Aug 22, 2023

Conversation

Sahiba3108
Copy link
Collaborator

@Sahiba3108 Sahiba3108 commented Aug 22, 2023

πŸ”© Description: What code changed, and why?

Increase the FQDN check wait time and retries

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-5794

πŸ‘ Definition of Done

Increased the fqdn check time to 1 min, and it will retry after every 5 sec till it got all the response or 1 min is completed.

πŸ‘Ÿ How to Build and Test the Change

Install this cli: hab pkg install sahiba3108/automate-cli/0.1.0/20230822072259 -bf

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Demo video: https://progresssoftware-my.sharepoint.com/:v:/g/personal/sgoyal_progress_com/ETdqhx5wT6FNpNDiT0i5t38B375UPMX_yEi4InfZHDH3ow?e=VHgiJ4

Screenshot 2023-08-22 at 2 56 59 PM

Signed-off-by: Sahiba3108 <sgoyal@progress.com>
@netlify
Copy link

netlify bot commented Aug 22, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit a894c7b
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64e46eb419717e0008fc891f

@Sahiba3108 Sahiba3108 self-assigned this Aug 22, 2023
@sonarqube-for-infrastructure-prod

@Dmaddu Dmaddu merged commit 76330e3 into main Aug 22, 2023
6 of 8 checks passed
@Dmaddu Dmaddu deleted the sahiba/fqdn-check-fix branch August 22, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants