Fixing bug - to take region from input while making AWS connection #8149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
When the user is configuring S3 as a backup in AWS, the verify command fails for S3-backup-check in the pre-deployment flow with the following error in the screenshot.
Reason:
While creating a new session in AWS the region is not taken. So the session created is not proper and unable to connect to the bucket, as it takes us-east-1 as the default region and the user bucket is in the ap-south-1 region.
Other issue:
https://s3.REGION.amazonaws.com
. For https://s3.amazonaws.com , it consider it as the bucket is in us-east-1 (default region)To fix this, the endpoint URL is programmatically changed to the
https://s3.REGION.amazonaws.com
pattern which is only applicable to the AWS S3 bucket endpoint URL.⛓️ Related Resources
Jira ticket: https://chefio.atlassian.net/browse/CHEF-5820
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
AWS:
On-Prem:
AWS s3:
MinIO: