Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing cleanup command to ignore uninstalling hab workspace #8154

Merged
merged 3 commits into from Aug 29, 2023

Conversation

ArvinthC3000
Copy link
Collaborator

@ArvinthC3000 ArvinthC3000 commented Aug 24, 2023

🔩 Description: What code changed, and why?

When the cleanup command is triggered, it should not delete the hab deployment workspace

⛓️ Related Resources

Jira: https://chefio.atlassian.net/browse/CHEF-2769

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2023-08-28 at 11 47 06 PM

In case of error, command message won't be shown
image

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit a8a22f3
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64ece5cd026dc0000845d762
😎 Deploy Preview https://deploy-preview-8154--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate failed

Failed condition C Maintainability Rating on New Code (is worse than A)
Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@punitmundra punitmundra merged commit 7411356 into main Aug 29, 2023
5 of 8 checks passed
@punitmundra punitmundra deleted the ar/fix_cleanup branch August 29, 2023 07:34
talktovikas pushed a commit that referenced this pull request Aug 29, 2023
* Fixing cleanup command to ignore uninstalling hab workspace

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Removing success message

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Updating cleanup

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

---------

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
talktovikas pushed a commit that referenced this pull request Aug 29, 2023
* Fixing cleanup command to ignore uninstalling hab workspace

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Removing success message

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Updating cleanup

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

---------

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@ArvinthC3000 ArvinthC3000 self-assigned this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants