Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential check before gcp backup check #8215

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Conversation

daveaugustus
Copy link
Contributor

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

image

@daveaugustus daveaugustus requested a review from a team September 12, 2023 13:06
@daveaugustus daveaugustus marked this pull request as ready for review September 12, 2023 13:26
@daveaugustus daveaugustus self-assigned this Sep 12, 2023
SahithiMy and others added 4 commits September 12, 2023 19:32
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
@sonarqube-for-infrastructure-prod

@Dmaddu Dmaddu merged commit fd23a6d into feature/CHEF-5280 Sep 12, 2023
5 of 7 checks passed
@Dmaddu Dmaddu deleted the check_credentials branch September 12, 2023 15:41
Dmaddu added a commit that referenced this pull request Sep 13, 2023
…ket.gs (#8133)

* Added GCP config struct

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Added gcp values

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* gcs values for batch check (#8150)

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>

* added values for config parser (#8141)

* added values for config parser

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* modified gcs values in config parser

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Added test cases

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* modified field name

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* handled location empty case

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Pr comments

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* pipeline trigger

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* pipeline fix

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* pipeline fix

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

---------

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>

* pull and generate for gcp config

Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>

* Retreved changes and removed duplicate variables

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* retrieved mapping config parser changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Create The API for checking the GCS config (#8159)

* added values for config parser

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* modified gcs values in config parser

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Added test cases

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Pr comments

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Modification based on the credential file path

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Pipeline trigger

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* moving changes in json file

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* moving changes in json file

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* moving rebase conflict changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* added values for config parser

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* modified gcs values in config parser

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Pr comments

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Initial commit for GCP APi

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Added GetGCPConnection test

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Removed rebased not required changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Just a save

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* API check connection success

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* API done, test cases remain

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Removed copied changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Resolution msg correction and rebased

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Unit test cases for the handler

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Mocked tests for the service

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Added UUID and gcpUtils

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Modified mock

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Added changes based on mock

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Done with API changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Improvised test cases

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Removed unused variables

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Improvised code

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Moved utils to services

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Contex added, modified the return type of NewGCPUtils() func

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* updated mod file

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* updating the code

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* updating to internal logger

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* If connection fails than dont check for access

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

---------

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>

* GCS Post Verification (#8176)

Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>

* Sahithi/chef 5614 (#8167)

* added values for config parser

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* modified gcs values in config parser

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Added test cases

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Pr comments

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Modification based on the credential file path

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Pipeline trigger

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* moving changes in json file

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* moving changes in json file

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* moving rebase conflict changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* added values for config parser

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* modified gcs values in config parser

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Pr comments

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Initial commit for GCP APi

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Removed rebased not required changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Just a save

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Removed copied changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Mocked tests for the service

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Added UUID and gcpUtils

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Modified mock

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Added changes based on mock

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Done with API changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Improvised test cases

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Removed unused variables

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Improvised code

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Moved utils to services

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Contex added, modified the return type of NewGCPUtils() func

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* updating the code

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* Mapped config parser

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Modification based on the credential file path

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* trigger check for gcs

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* adding location

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* rebasing

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* rebasing conflicts

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* fixed conflict issues

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* rebasing

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

---------

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>
Co-authored-by: Pappu Kumar <pappu.kumar@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>

* fixing config gen verify flow (#8211)

* fixing config gen verify flow

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Improved test cases

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* testcase fix

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* changes for unmarshall

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* testcase fix

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

---------

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>

* Credential check before gcp backup check (#8215)

* fixing config gen verify flow

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* testcase fix

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* changes for unmarshall

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Credential check before gcp backup check

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* repo health pipeline corrected

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

---------

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>

---------

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>
Co-authored-by: SahithiMy <98326242+SahithiMy@users.noreply.github.com>
Co-authored-by: “SanjuPal01” <sanju.sanju@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>
Co-authored-by: Sanju Pal <101255220+SanjuPal01@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants