Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing duplicate IPs for 5 node cluster #8251

Merged
merged 3 commits into from Oct 12, 2023
Merged

Conversation

ArvinthC3000
Copy link
Collaborator

🔩 Description: What code changed, and why?

As an Automate HA user, when I use 5 node cluster, it shows the error as follow:
image

This is because the IPs are repeated and and systemd-service create is executing twice at the same time.

In this PR, the duplicate IP are removed so the verify will run without errors.
Screenshot: https://progresssoftware.sharepoint.com/:i:/s/ChefCoreC/EcPSQyX-U11Es7dcKyucnl4BwTLEuKg9zOgVt5UN0BX6Aw?e=ql9ieM

⛓️ Related Resources

Jira: https://chefio.atlassian.net/browse/CHEF-6207

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

For 5 node cluster (or minimum node cluster)
https://progresssoftware.sharepoint.com/:i:/s/ChefCoreC/EcPSQyX-U11Es7dcKyucnl4BwTLEuKg9zOgVt5UN0BX6Aw?e=ql9ieM

@netlify
Copy link

netlify bot commented Oct 10, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit cab1ff4
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6527b0d520ab8c00084f1f37

@ArvinthC3000 ArvinthC3000 self-assigned this Oct 10, 2023
@sonarqube-for-infrastructure-prod

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@punitmundra punitmundra merged commit ebad837 into main Oct 12, 2023
4 of 7 checks passed
@punitmundra punitmundra deleted the ar/verify_for_5_node branch October 12, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants