Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralised Logging throwing error invalid config for PG and OS in automate HA #8259

Merged
merged 5 commits into from Oct 23, 2023

Conversation

bvtejaswi
Copy link
Collaborator

@bvtejaswi bvtejaswi commented Oct 12, 2023

🔩 Description: What code changed, and why?

While patching centralised logging after successful patch in the end its exiting with an error which is thrown from pg config patch flow ,to avoid this the changes were made to exit from the flow right after successful centralised log patch.

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-6209

👍 Definition of Done

Tested config patch with following types of configs :

  • patch with only centralised log config
  • patch with only pg/os config
  • patch with both centralised log and pg/os config
  • patch with centralised log config in frontend
  • patch with non centralised log config in frontend

👟 How to Build and Test the Change

build automate-cli and install in bastion

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Demo video
screen shot

@netlify
Copy link

netlify bot commented Oct 12, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit a2b9f52
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/652e3956e520da000855ca51

Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>
Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>
Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate failed

Failed condition 66.0% 66.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>
Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>
@punitmundra punitmundra merged commit 3d24f57 into main Oct 23, 2023
4 of 7 checks passed
@punitmundra punitmundra deleted the bvtejaswi/CHEF6029 branch October 23, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants