New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jay/chef 6031 #8261
Merged
Merged
Jay/chef 6031 #8261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing.
|
jayvikramsharma1
force-pushed
the
jay/CHEF-6031
branch
from
October 16, 2023 05:29
aecdb69
to
4f4745c
Compare
jayvikramsharma1
requested review from
vivek-yadav,
punitmundra,
Dmaddu,
ArvinthC3000 and
bvtejaswi
October 16, 2023 05:32
punitmundra
reviewed
Oct 18, 2023
bvtejaswi
reviewed
Oct 23, 2023
punitmundra
reviewed
Oct 25, 2023
components/automate-cli/cmd/chef-automate/automateHADeployExistingInfra.go
Outdated
Show resolved
Hide resolved
Signed-off-by: punitmundra <pmundra@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
jayvikramsharma1
force-pushed
the
jay/CHEF-6031
branch
from
October 25, 2023 07:54
91e7c86
to
0aed8f1
Compare
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
github-actions
bot
added
the
documentation
Anything related to the Automate docs.
label
Oct 27, 2023
punitmundra
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do resolve the comment
vivek-yadav
approved these changes
Nov 2, 2023
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
swatiganesh
pushed a commit
that referenced
this pull request
Apr 16, 2024
* add the certificate template Signed-off-by: punitmundra <pmundra@progress.com> * cert rotate from template Signed-off-by: Jay Sharma <jsharma@progress.com> * patching frontend config Signed-off-by: Jay Sharma <jsharma@progress.com> * cluster certificate patch working code Signed-off-by: Jay Sharma <jsharma@progress.com> * putting frontend on maintenance mode before rotating certws Signed-off-by: Jay Sharma <jsharma@progress.com> * added test cases for get certs form template Signed-off-by: Jay Sharma <jsharma@progress.com> * correction of filename in cert-config generation Signed-off-by: Jay Sharma <jsharma@progress.com> * adding more test cases Signed-off-by: Jay Sharma <jsharma@progress.com> * adding validation on certificates before stopping traffic to frontends Signed-off-by: Jay Sharma <jsharma@progress.com> * adding defer statement to turn off maintenance mode Signed-off-by: Jay Sharma <jsharma@progress.com> * replacing fmt with logger Signed-off-by: Jay Sharma <jsharma@progress.com> * adding exclution on testcase pem files Signed-off-by: Jay Sharma <jsharma@progress.com> * adding testfile in credscan excl;ustion Signed-off-by: Jay Sharma <jsharma@progress.com> * fixing failing testcases Signed-off-by: Jay Sharma <jsharma@progress.com> * adding docs Signed-off-by: Jay Sharma <jsharma@progress.com> * resolving review comments Signed-off-by: Jay Sharma <jsharma@progress.com> * regfactoring Signed-off-by: Jay Sharma <jsharma@progress.com> --------- Signed-off-by: punitmundra <pmundra@progress.com> Signed-off-by: Jay Sharma <jsharma@progress.com> Co-authored-by: punitmundra <pmundra@progress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Rotate cluster certificate at once
⛓️ Related Resources
https://chefio.atlassian.net/browse/CHEF-6031
https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/EbrFjpcILt9GqdufQPDGqXgB0vEQGSQfhMbl3T4ijjHAhA?e=lQJRqx
👍 Definition of Done
Dev tested
👟 How to Build and Test the Change
automate-cli build
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/EbrFjpcILt9GqdufQPDGqXgB0vEQGSQfhMbl3T4ijjHAhA?e=lQJRqx