Update the run hook to skip the pg-helper for non bootstrap node #8275

punitmundra · 2023-10-23T10:16:41Z

🔩 Description: What code changed, and why?

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-4179
https://chefio.atlassian.net/browse/CHEF-7293
https://chefio.atlassian.net/browse/CHEF-7294

👍 Definition of Done

Demo Video : https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/Ed0KiczNVuFIjvW6GY_g8Q4BWMUcbIvTaifG8amioCRXkA?e=j8fHLh

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

I have read the CONTRIBUTING document.
All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

Tests added/updated? (all new code needs new tests)
Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

netlify · 2023-10-23T10:16:47Z

✅ Deploy Preview for chef-automate ready!

Name	Link
🔨 Latest commit	`db13942`
🔍 Latest deploy log	https://app.netlify.com/sites/chef-automate/deploys/656829690edb320008b5a909
😎 Deploy Preview	https://deploy-preview-8275--chef-automate.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

lib/db/migrator/migrator.go

components/automate-cli/cmd/chef-automate/ha_node_add.go

sonarqube-for-infrastructure-prod · 2023-11-21T13:20:37Z

SonarQube Quality Gate

19.4% Coverage on New Code (is less than 80%)
9.13% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

punitmundra · 2023-11-29T10:23:51Z

@jashaik @marcparadise : could you please review and approve this PR

jashaik · 2023-11-30T06:01:58Z

LGTM.

Signed-off-by: punitmundra <pmundra@progress.com>

Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>

Signed-off-by: punitmundra <pmundra@progress.com>

* resolve conflict during rebase Signed-off-by: punitmundra <pmundra@progress.com> * add the skip migration code in the lib/db Signed-off-by: punitmundra <pmundra@progress.com> * add the todo for upgrade and add-node command for now Signed-off-by: punitmundra <pmundra@progress.com> * add the check for the addnode in deployment script Signed-off-by: punitmundra <pmundra@progress.com> * update the frontend bundle in the args Signed-off-by: punitmundra <pmundra@progress.com> * add changes for upgrade Signed-off-by: punitmundra <pmundra@progress.com> * fix reported by semgrep Signed-off-by: punitmundra <pmundra@progress.com> * add condition in add-node Signed-off-by: punitmundra <pmundra@progress.com> * review comments Signed-off-by: punitmundra <pmundra@progress.com> * remove double quotes from the bundle name Signed-off-by: punitmundra <pmundra@progress.com> * remove double quotes from the bundle name Signed-off-by: punitmundra <pmundra@progress.com> * add the new func for the FE to get the output Signed-off-by: punitmundra <pmundra@progress.com> * merge conflicts 01 Signed-off-by: punitmundra <pmundra@progress.com> * just to make build success Signed-off-by: punitmundra <pmundra@progress.com> * unpin the deps in plan.sh Signed-off-by: punitmundra <pmundra@progress.com> * update the template to avoid the conflit for variable Signed-off-by: punitmundra <pmundra@progress.com> * code fix for shell scritp Signed-off-by: punitmundra <pmundra@progress.com> * removed print statements Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com> * resolving status summary panic error Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com> * add 1 test case and go.mod Signed-off-by: punitmundra <pmundra@progress.com> * remove the echo from the run hook Signed-off-by: punitmundra <pmundra@progress.com> --------- Signed-off-by: punitmundra <pmundra@progress.com> Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com> Co-authored-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>

punitmundra changed the title ~~update the run hook to skip the pg-helper for non bootstrap node~~ [DRAFT]update the run hook to skip the pg-helper for non bootstrap node Oct 23, 2023

semgrep-app bot reviewed Oct 23, 2023

View reviewed changes

lib/db/migrator/migrator.go Outdated Show resolved Hide resolved

punitmundra changed the title ~~[DRAFT]update the run hook to skip the pg-helper for non bootstrap node~~ Update the run hook to skip the pg-helper for non bootstrap node Nov 2, 2023

punitmundra requested review from vivek-yadav, jayvikramsharma1, ArvinthC3000 and bvtejaswi November 2, 2023 09:16

punitmundra force-pushed the CHEF-4179 branch from 957525d to d63943f Compare November 3, 2023 09:07

semgrep-app bot reviewed Nov 3, 2023

View reviewed changes

components/automate-cli/cmd/chef-automate/ha_node_add.go Outdated Show resolved Hide resolved

semgrep-app bot reviewed Nov 3, 2023

View reviewed changes

components/automate-cli/cmd/chef-automate/ha_node_add.go Outdated Show resolved Hide resolved

bvtejaswi approved these changes Nov 17, 2023

View reviewed changes

punitmundra force-pushed the CHEF-4179 branch from d735b31 to 1325671 Compare November 21, 2023 12:54

punitmundra requested review from marcparadise and jashaik November 24, 2023 05:57

punitmundra requested a review from kalroy November 30, 2023 05:47

jashaik approved these changes Nov 30, 2023

View reviewed changes

punitmundra added 10 commits November 30, 2023 11:46

resolve conflict during rebase

66cdfbd

Signed-off-by: punitmundra <pmundra@progress.com>

add the skip migration code in the lib/db

3deed58

Signed-off-by: punitmundra <pmundra@progress.com>

add the todo for upgrade and add-node command for now

6108994

Signed-off-by: punitmundra <pmundra@progress.com>

add the check for the addnode in deployment script

4756392

Signed-off-by: punitmundra <pmundra@progress.com>

update the frontend bundle in the args

63be850

Signed-off-by: punitmundra <pmundra@progress.com>

add changes for upgrade

9ae2803

Signed-off-by: punitmundra <pmundra@progress.com>

fix reported by semgrep

7a9d071

Signed-off-by: punitmundra <pmundra@progress.com>

add condition in add-node

054f776

Signed-off-by: punitmundra <pmundra@progress.com>

review comments

a8b73e9

Signed-off-by: punitmundra <pmundra@progress.com>

remove double quotes from the bundle name

ca8bff9

Signed-off-by: punitmundra <pmundra@progress.com>

punitmundra and others added 11 commits November 30, 2023 11:47

remove double quotes from the bundle name

7762ad3

Signed-off-by: punitmundra <pmundra@progress.com>

add the new func for the FE to get the output

69752a3

Signed-off-by: punitmundra <pmundra@progress.com>

merge conflicts 01

f4aaa76

Signed-off-by: punitmundra <pmundra@progress.com>

just to make build success

2bb3ede

Signed-off-by: punitmundra <pmundra@progress.com>

unpin the deps in plan.sh

bcbd22c

Signed-off-by: punitmundra <pmundra@progress.com>

update the template to avoid the conflit for variable

0f3d189

Signed-off-by: punitmundra <pmundra@progress.com>

code fix for shell scritp

12421e2

Signed-off-by: punitmundra <pmundra@progress.com>

removed print statements

64570ce

Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>

resolving status summary panic error

1de6b6b

Signed-off-by: Tejaswi Bondila <bondila.venkatatejaswi@progress.com>

add 1 test case and go.mod

b808165

Signed-off-by: punitmundra <pmundra@progress.com>

remove the echo from the run hook

db13942

Signed-off-by: punitmundra <pmundra@progress.com>

punitmundra force-pushed the CHEF-4179 branch from 1325671 to db13942 Compare November 30, 2023 06:19

punitmundra merged commit 09d0c49 into main Nov 30, 2023
4 of 7 checks passed

punitmundra deleted the CHEF-4179 branch November 30, 2023 06:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the run hook to skip the pg-helper for non bootstrap node #8275

Update the run hook to skip the pg-helper for non bootstrap node #8275

punitmundra commented Oct 23, 2023 •

edited

netlify bot commented Oct 23, 2023 •

edited

sonarqube-for-infrastructure-prod bot commented Nov 21, 2023

punitmundra commented Nov 29, 2023

jashaik commented Nov 30, 2023

Update the run hook to skip the pg-helper for non bootstrap node #8275

Update the run hook to skip the pg-helper for non bootstrap node #8275

Conversation

punitmundra commented Oct 23, 2023 • edited

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

📷 Screenshots, if applicable

netlify bot commented Oct 23, 2023 • edited

✅ Deploy Preview for chef-automate ready!

sonarqube-for-infrastructure-prod bot commented Nov 21, 2023

punitmundra commented Nov 29, 2023

jashaik commented Nov 30, 2023

punitmundra commented Oct 23, 2023 •

edited

netlify bot commented Oct 23, 2023 •

edited