-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding check in system-user verify flow to verify HAB uid #8290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
👷 Deploy Preview for chef-automate processing.
|
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
ArvinthC3000
requested review from
vivek-yadav,
jayvikramsharma1,
punitmundra,
karunesh-tech and
bvtejaswi
November 8, 2023 11:07
ArvinthC3000
changed the title
[WIP]Adding check in system-user verify flow to verify HAB uid
Adding check in system-user verify flow to verify HAB uid
Nov 8, 2023
bvtejaswi
approved these changes
Nov 9, 2023
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
punitmundra
reviewed
Nov 20, 2023
punitmundra
reviewed
Nov 20, 2023
punitmundra
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am approving the pr just resolve the 2 comments
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
SonarQube Quality Gate |
anees-progress
pushed a commit
that referenced
this pull request
Nov 30, 2023
* Adding hab uid check in system-user verify flow Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * Removing logconfig changes Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * code coveragr Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * refactoring for code smell and removing nil pointers Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * Test coverage Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * Review comments Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> --------- Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
anees-progress
pushed a commit
that referenced
this pull request
Nov 30, 2023
* Adding hab uid check in system-user verify flow Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * Removing logconfig changes Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * code coveragr Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * refactoring for code smell and removing nil pointers Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * Test coverage Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * Review comments Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> --------- Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
swatiganesh
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Adding hab uid check in system-user verify flow Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * Removing logconfig changes Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * code coveragr Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * refactoring for code smell and removing nil pointers Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * Test coverage Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> * Review comments Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com> --------- Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
As an automate HA user, when I use File system as backup, then while running verify flow, I should also verify if the hab uid is same across all the remote nodes. If not verify check should show the error.
efs
(AWS) orfile_system
(on-prem)⛓️ Related Resources
Jira ticket: https://chefio.atlassian.net/browse/CHEF-6390
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Screentshot: Verify check for hab uid in remote nodes - faliure
Demo Video: Verify check for hab uid in remote nodes