Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding check in system-user verify flow to verify HAB uid #8290

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

ArvinthC3000
Copy link
Collaborator

@ArvinthC3000 ArvinthC3000 commented Nov 6, 2023

🔩 Description: What code changed, and why?

As an automate HA user, when I use File system as backup, then while running verify flow, I should also verify if the hab uid is same across all the remote nodes. If not verify check should show the error.

  • This is applicable only when the backup type is efs (AWS) or file_system (on-prem)
  • Check should be ignored when s3 or object storage is chosen.
  • Check should be ignored when no backup type is chosen

⛓️ Related Resources

Jira ticket: https://chefio.atlassian.net/browse/CHEF-6390

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screentshot: Verify check for hab uid in remote nodes - faliure
Demo Video: Verify check for hab uid in remote nodes

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Copy link

netlify bot commented Nov 6, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 47b3a03
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/655c41375102890008ab7ee3

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@ArvinthC3000 ArvinthC3000 changed the title [WIP]Adding check in system-user verify flow to verify HAB uid Adding check in system-user verify flow to verify HAB uid Nov 8, 2023
@ArvinthC3000 ArvinthC3000 self-assigned this Nov 8, 2023
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Copy link
Collaborator

@punitmundra punitmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am approving the pr just resolve the 2 comments

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@punitmundra punitmundra merged commit 5eb2df5 into main Nov 21, 2023
5 of 7 checks passed
@punitmundra punitmundra deleted the ar/systemUser_fs branch November 21, 2023 05:46

anees-progress pushed a commit that referenced this pull request Nov 30, 2023
* Adding hab uid check in system-user verify flow

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Removing logconfig changes

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* code coveragr

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* refactoring for code smell and removing nil pointers

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Test coverage

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Review comments

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

---------

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
anees-progress pushed a commit that referenced this pull request Nov 30, 2023
* Adding hab uid check in system-user verify flow

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Removing logconfig changes

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* code coveragr

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* refactoring for code smell and removing nil pointers

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Test coverage

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Review comments

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

---------

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
swatiganesh pushed a commit that referenced this pull request Apr 16, 2024
* Adding hab uid check in system-user verify flow

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Removing logconfig changes

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* code coveragr

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* refactoring for code smell and removing nil pointers

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Test coverage

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Review comments

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

---------

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants