Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remvoing config patch for old configs in upgrade and add/remove node #8296

Merged
merged 4 commits into from Nov 29, 2023

Conversation

ArvinthC3000
Copy link
Collaborator

@ArvinthC3000 ArvinthC3000 commented Nov 20, 2023

🔩 Description: What code changed, and why?

When user upgrade the bundle to latest, some configuration belongs to Automate config which are updated are reverting back to initial values. In this PR, that is addressed

⛓️ Related Resources

Jira ticket: https://chefio.atlassian.net/browse/CHEF-8418

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

In the below screenshot, when the deployment done, the original base path highlighted would be "elasticsearch", which lated updated to "opensearch".

After upgrade, the same value is intact
Screenshot

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Copy link

netlify bot commented Nov 20, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit bae31db
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/655c448a07e5ff0008f748f6

Copy link
Collaborator

@punitmundra punitmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump the package automate-backend-deploment

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
@ArvinthC3000 ArvinthC3000 self-assigned this Nov 21, 2023
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@punitmundra punitmundra merged commit 479b61b into main Nov 29, 2023
5 of 7 checks passed
@punitmundra punitmundra deleted the ar/CHEF-8418 branch November 29, 2023 10:26
anees-progress pushed a commit that referenced this pull request Nov 30, 2023
…8296)

* Remoing config patch for old configs in upgrade and add/remove node

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Trigger build

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Stash for save and sync config for upgrade flow

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Removing stash

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

---------

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
anees-progress pushed a commit that referenced this pull request Nov 30, 2023
…8296)

* Remoing config patch for old configs in upgrade and add/remove node

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Trigger build

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Stash for save and sync config for upgrade flow

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Removing stash

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

---------

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
swatiganesh pushed a commit that referenced this pull request Apr 16, 2024
…8296)

* Remoing config patch for old configs in upgrade and add/remove node

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Trigger build

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Stash for save and sync config for upgrade flow

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

* Removing stash

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>

---------

Signed-off-by: Arvinth C <arvinth.chandrasekaran@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants