Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes in Automate All view not showing normal precedence #8319

Merged
merged 1 commit into from Dec 5, 2023

Conversation

vinay033
Copy link
Collaborator

@vinay033 vinay033 commented Dec 1, 2023

πŸ”© Description: What code changed, and why?

Node attributes displayed in the Infrastructure tab under the All view are not displaying values in proper precedence. For example, we have a cookbook that defines a default attribute value and the node has defined a normal attribute value which displays properly under the Default and Normal views, but under the All view, it is not showing the Normal value.

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-5829

πŸ‘ Definition of Done

I have added changes to fix this bug.

πŸ‘Ÿ How to Build and Test the Change

Set up a cookbook that defines a default attribute value and a node with a defined normal attribute value, and run the cookbook against the node. Look at the Infrastructure tab under the All view and by the rules of precedence, we would expect the All view to show the "normal" value.

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Chef-Automate.mp4

Signed-off-by: vinay sharma <vsharma@chef.io>
Copy link

netlify bot commented Dec 1, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit acaf1db
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6569bb3835602a000807c806

@kalroy kalroy merged commit 14adbb4 into main Dec 5, 2023
4 of 7 checks passed
@kalroy kalroy deleted the Vinay/fix_attribute_bug_CHEF-5829 branch December 5, 2023 10:13
swatiganesh pushed a commit that referenced this pull request Apr 16, 2024
Signed-off-by: vinay sharma <vsharma@chef.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants